Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALPN extension to client SSL Context #10156

Merged
merged 9 commits into from
Dec 12, 2024

Conversation

Cycloctane
Copy link
Contributor

@Cycloctane Cycloctane commented Dec 11, 2024

What do these changes do?

Add "http/1.1" ALPN extension to aiohttp client's SSL Context.

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Fixes #10152

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder

@Cycloctane Cycloctane requested a review from asvetlov as a code owner December 11, 2024 09:04
@Cycloctane Cycloctane requested a review from webknjaz as a code owner December 11, 2024 09:09
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 11, 2024
@bdraco bdraco added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (7f8e2d3) to head (4b84a46).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10156   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         122      122           
  Lines       36954    36970   +16     
  Branches     4411     4411           
=======================================
+ Hits        36494    36510   +16     
  Misses        313      313           
  Partials      147      147           
Flag Coverage Δ
CI-GHA 98.64% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.33% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.17% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.43% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.27% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.81% <100.00%> (-0.06%) ⬇️
Py-3.11.10 97.86% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.32% <100.00%> (-0.01%) ⬇️
Py-3.12.7 98.38% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 97.19% <100.00%> (-0.01%) ⬇️
Py-3.13.1 98.35% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.20% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.73% <100.00%> (-0.05%) ⬇️
Py-pypy7.3.16 97.35% <100.00%> (-0.01%) ⬇️
VM-macos 97.43% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.33% <100.00%> (+<0.01%) ⬆️
VM-windows 96.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 11, 2024

CodSpeed Performance Report

Merging #10156 will not alter performance

Comparing Cycloctane:support_alpn (4b84a46) with master (3f07b1a)

Summary

✅ 47 untouched benchmarks

aiohttp/connector.py Outdated Show resolved Hide resolved
@Dreamsorcerer Dreamsorcerer merged commit 0070045 into aio-libs:master Dec 12, 2024
40 checks passed
Copy link
Contributor

patchback bot commented Dec 12, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/00700458eb7741f15861a8616dbf77a0d82dc31f/pr-10156

Backported as #10163

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 12, 2024
Copy link
Contributor

patchback bot commented Dec 12, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/00700458eb7741f15861a8616dbf77a0d82dc31f/pr-10156

Backported as #10164

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

asvetlov pushed a commit that referenced this pull request Dec 12, 2024
…Context (#10164)

**This is a backport of PR #10156 as merged into master
(0070045).**

## What do these changes do?

Add "http/1.1" ALPN extension to aiohttp client's SSL Context.

## Are there changes in behavior for the user?

## Is it a substantial burden for the maintainers to support this?

## Related issue number

Fixes #10152 

## Checklist

- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [ ] Documentation reflects the changes
- [x] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
  * The format is &lt;Name&gt; &lt;Surname&gt;.
  * Please keep alphabetical order, the file is sorted by names.
- [x] Add a new news fragment into the `CHANGES/` folder

Co-authored-by: Cycloctane <[email protected]>
asvetlov pushed a commit that referenced this pull request Dec 12, 2024
…Context (#10163)

**This is a backport of PR #10156 as merged into master
(0070045).**

## What do these changes do?

Add "http/1.1" ALPN extension to aiohttp client's SSL Context.

## Are there changes in behavior for the user?

## Is it a substantial burden for the maintainers to support this?

## Related issue number

Fixes #10152 

## Checklist

- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [ ] Documentation reflects the changes
- [x] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
  * The format is &lt;Name&gt; &lt;Surname&gt;.
  * Please keep alphabetical order, the file is sorted by names.
- [x] Add a new news fragment into the `CHANGES/` folder

Co-authored-by: Cycloctane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ALPN extension in client
3 participants