Add support for ALPN extension in client #10152
Labels
Comments
1 task
5 tasks
This was referenced Dec 12, 2024
asvetlov
pushed a commit
that referenced
this issue
Dec 12, 2024
…Context (#10164) **This is a backport of PR #10156 as merged into master (0070045).** ## What do these changes do? Add "http/1.1" ALPN extension to aiohttp client's SSL Context. ## Are there changes in behavior for the user? ## Is it a substantial burden for the maintainers to support this? ## Related issue number Fixes #10152 ## Checklist - [x] I think the code is well written - [x] Unit tests for the changes exist - [ ] Documentation reflects the changes - [x] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [x] Add a new news fragment into the `CHANGES/` folder Co-authored-by: Cycloctane <[email protected]>
asvetlov
pushed a commit
that referenced
this issue
Dec 12, 2024
…Context (#10163) **This is a backport of PR #10156 as merged into master (0070045).** ## What do these changes do? Add "http/1.1" ALPN extension to aiohttp client's SSL Context. ## Are there changes in behavior for the user? ## Is it a substantial burden for the maintainers to support this? ## Related issue number Fixes #10152 ## Checklist - [x] I think the code is well written - [x] Unit tests for the changes exist - [ ] Documentation reflects the changes - [x] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [x] Add a new news fragment into the `CHANGES/` folder Co-authored-by: Cycloctane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
aiohttp client doesn't send ALPN (TLS application_layer_protocol_negotiation extension). Some servers may refuse to do handshake with clients or block requests without this extension set in TLS layer. (As in #8478 , #10141 )
It has been implemented in cpython's urllib and curl. (https://bugs.python.org/issue40968) So I think enabling this in aiohttp is necessary.
Describe the solution you'd like
aiohttp client only uses http/1.1 protocol for now. Simply setting it by
set_alpn_protocols['http/1.1']after creating SSL default context should be fine.Describe alternatives you've considered
none
Related component
Client
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: