Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10125/d58d2c3d backport][3.12] Disable zero copy writes in the StreamWriter #10127

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Dec 5, 2024

This is a backport of PR #10125 as merged into master (d58d2c3).

python/cpython#127656

Zero copy writes will return in a future version once a new cpython version is released.

@bdraco bdraco enabled auto-merge (squash) December 5, 2024 22:12
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #10127 will degrade performances by 21.18%

Comparing patchback/backports/3.12/d58d2c3d0f8755dcd982071e3dc12e9f14db55f6/pr-10125 (78cddd6) with 3.12 (da4e00b)

Summary

❌ 1 (👁 1) regressions
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark 3.12 patchback/backports/3.12/d58d2c3d0f8755dcd982071e3dc12e9f14db55f6/pr-10125 Change
👁 test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop] 168.2 ms 213.4 ms -21.18%

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (da4e00b) to head (78cddd6).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.12   #10127      +/-   ##
==========================================
- Coverage   98.06%   98.05%   -0.02%     
==========================================
  Files         123      123              
  Lines       37143    37141       -2     
  Branches     4465     4468       +3     
==========================================
- Hits        36425    36419       -6     
- Misses        540      544       +4     
  Partials      178      178              
Flag Coverage Δ
CI-GHA 97.94% <100.00%> (-0.02%) ⬇️
OS-Linux 97.64% <100.00%> (-0.02%) ⬇️
OS-Windows 94.57% <100.00%> (-0.02%) ⬇️
OS-macOS 96.76% <100.00%> (-0.02%) ⬇️
Py-3.10.11 96.61% <100.00%> (-0.02%) ⬇️
Py-3.10.15 97.19% <100.00%> (+0.02%) ⬆️
Py-3.11.10 97.22% <100.00%> (-0.02%) ⬇️
Py-3.11.9 96.69% <100.00%> (-0.02%) ⬇️
Py-3.12.7 97.71% <100.00%> (-0.02%) ⬇️
Py-3.13.0 96.54% <100.00%> (-0.02%) ⬇️
Py-3.13.1 97.68% <100.00%> (-0.02%) ⬇️
Py-3.9.13 96.54% <100.00%> (-0.02%) ⬇️
Py-3.9.20 97.08% <100.00%> (-0.05%) ⬇️
Py-pypy7.3.16 96.68% <100.00%> (-0.03%) ⬇️
VM-macos 96.76% <100.00%> (-0.02%) ⬇️
VM-ubuntu 97.64% <100.00%> (-0.02%) ⬇️
VM-windows 94.57% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 6462f75 into 3.12 Dec 5, 2024
33 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/d58d2c3d0f8755dcd982071e3dc12e9f14db55f6/pr-10125 branch December 5, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant