Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable zero copy writes in the StreamWriter #10125

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 5, 2024

python/cpython#127656

Zero copy writes will return in a future version once a new cpython version is released. #10137 will restore them in the future.

@bdraco bdraco added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Dec 5, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (703ce61) to head (e3760a3).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10125      +/-   ##
==========================================
- Coverage   98.76%   98.74%   -0.02%     
==========================================
  Files         122      122              
  Lines       36958    36956       -2     
  Branches     4408     4411       +3     
==========================================
- Hits        36500    36494       -6     
- Misses        311      315       +4     
  Partials      147      147              
Flag Coverage Δ
CI-GHA 98.63% <100.00%> (-0.02%) ⬇️
OS-Linux 98.32% <100.00%> (-0.02%) ⬇️
OS-Windows 96.17% <100.00%> (-0.02%) ⬇️
OS-macOS 97.42% <100.00%> (-0.02%) ⬇️
Py-3.10.11 97.27% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.81% <100.00%> (-0.02%) ⬇️
Py-3.11.10 97.85% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.32% <100.00%> (-0.03%) ⬇️
Py-3.12.7 98.37% <100.00%> (-0.02%) ⬇️
Py-3.13.0 97.18% <100.00%> (-0.02%) ⬇️
Py-3.13.1 98.34% <100.00%> (-0.02%) ⬇️
Py-3.9.13 97.19% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.73% <100.00%> (-0.06%) ⬇️
Py-pypy7.3.16 97.34% <100.00%> (-0.01%) ⬇️
VM-macos 97.42% <100.00%> (-0.02%) ⬇️
VM-ubuntu 98.32% <100.00%> (-0.02%) ⬇️
VM-windows 96.17% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #10125 will degrade performances by 21.19%

Comparing disable_zero_copy (e3760a3) with master (703ce61)

Summary

❌ 1 (👁 1) regressions
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark master disable_zero_copy Change
👁 test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop] 168 ms 213.2 ms -21.19%

@bdraco bdraco marked this pull request as ready for review December 5, 2024 22:07
@bdraco bdraco merged commit d58d2c3 into master Dec 5, 2024
41 checks passed
@bdraco bdraco deleted the disable_zero_copy branch December 5, 2024 22:11
Copy link
Contributor

patchback bot commented Dec 5, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/d58d2c3d0f8755dcd982071e3dc12e9f14db55f6/pr-10125

Backported as #10126

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Dec 5, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/d58d2c3d0f8755dcd982071e3dc12e9f14db55f6/pr-10125

Backported as #10127

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 5, 2024
bdraco added a commit that referenced this pull request Dec 5, 2024
bdraco added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant