-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable zero copy writes in the StreamWriter
#10125
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10125 +/- ##
==========================================
- Coverage 98.76% 98.74% -0.02%
==========================================
Files 122 122
Lines 36958 36956 -2
Branches 4408 4411 +3
==========================================
- Hits 36500 36494 -6
- Misses 311 315 +4
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10125 will degrade performances by 21.19%Comparing Summary
Benchmarks breakdown
|
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10126 🤖 @patchback |
(cherry picked from commit d58d2c3)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10127 🤖 @patchback |
(cherry picked from commit d58d2c3)
…`StreamWriter`` (#10126) Co-authored-by: J. Nick Koston <[email protected]>
…`StreamWriter`` (#10127) Co-authored-by: J. Nick Koston <[email protected]>
python/cpython#127656
Zero copy writes will return in a future version once a new cpython version is released. #10137 will restore them in the future.