-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xfailing integration tests against proxy.py
#6002
Add xfailing integration tests against proxy.py
#6002
Conversation
923cb41
to
fbecc4d
Compare
e631f76
to
a59d42e
Compare
a59d42e
to
293319a
Compare
I was running these with:
|
0aa61e8
to
aa3a8de
Compare
aa3a8de
to
e17bcf1
Compare
proxy.py
e17bcf1
to
881cabc
Compare
aa3a120
to
d405eee
Compare
This patch adds full end-to-end tests for sending requests to HTTP and HTTPS endpoints through an HTTPS proxy. The first case is currently supported and the second one is not. This is why the latter test is marked as expected to fail. The support for TLS-in-TLS in the upstream stdlib asyncio is currently disabled but is available in Python 3.9 via monkey-patching which is demonstrated in the added tests. Refs: * https://bugs.python.org/issue37179 * python/cpython#28073 * aio-libs#5992 Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
d405eee
to
1edb61a
Compare
Codecov Report
@@ Coverage Diff @@
## master #6002 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 44 44
Lines 9857 9857
Branches 1592 1592
=======================================
Hits 9537 9537
Misses 182 182
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply d66e07c on top of patchback/backports/3.8/d66e07c652322d280740106ebb9946a3dd7daf5b/pr-6002 Backporting merged PR #6002 into master
🤖 @patchback |
This patch adds full end-to-end tests for sending requests to HTTP and HTTPS endpoints through an HTTPS proxy. The first case is currently supported and the second one is not. This is why the latter test is marked as expected to fail. The support for TLS-in-TLS in the upstream stdlib asyncio is currently disabled but is available in Python 3.9 via monkey-patching which is demonstrated in the added tests. Refs: * https://bugs.python.org/issue37179 * python/cpython#28073 * aio-libs#5992 Co-authored-by: Sviatoslav Sydorenko <[email protected]> PR aio-libs#6002 (cherry picked from commit d66e07c)
…nst ``proxy.py`` (#6033) This patch adds full end-to-end tests for sending requests to HTTP and HTTPS endpoints through an HTTPS proxy. The first case is currently supported and the second one is not. This is why the latter test is marked as expected to fail. The support for TLS-in-TLS in the upstream stdlib asyncio is currently disabled but is available in Python 3.9 via monkey-patching which is demonstrated in the added tests. Refs: * https://bugs.python.org/issue37179 * python/cpython#28073 * #5992 Co-authored-by: bmbouter <[email protected]> Co-authored-by: Sviatoslav Sydorenko <[email protected]> PR #6002 (cherry picked from commit d66e07c)
I was running this with
pytest 'tests/test_proxy_functional.py::test_secure_proxy_http_absolute_path'
I tried using the TestCase from proxy.py but I want these as pytest fixtures and I couldn't find a way to call the trustme fixture and set the class attributes I need to here. So instead I'm "doing it like their TestCase" only as a fixture. This probably should go into proxy.py eventually, but here it is for now.