Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename changes to CHANGES #2130

Closed
asvetlov opened this issue Jul 26, 2017 · 8 comments
Closed

Rename changes to CHANGES #2130

asvetlov opened this issue Jul 26, 2017 · 8 comments
Labels
outdated

Comments

@asvetlov
Copy link
Member

The reason is: I want to see changes update in PR at very first place, it simplifies review.
Other option is changes -> CHANGES rename.

Opinions?
@asvetlov asvetlov changed the title Rename changes to _changes Rename changes to CHANGES Aug 2, 2017
@asvetlov
Copy link
Member Author

asvetlov commented Aug 2, 2017

If nobody object will do it after 2.3 release.

asvetlov added a commit that referenced this issue Oct 18, 2017
@asvetlov
Fix #2130: Rename changes to CHANGES
9f23498
webknjaz pushed a commit to webknjaz/aiohttp that referenced this issue Oct 18, 2017
@asvetlov @webknjaz
Fix aio-libs#2130: Rename changes to CHANGES
20aee26
@webknjaz
Copy link
Member

https://github.com/aio-libs/aiohttp/blob/master/pyproject.toml#L4 what about this?

@asvetlov
Copy link
Member Author

Good catch!
Fixed by b213d66

@webknjaz
Copy link
Member

why don't you just read that config to keep things in a single place?

@asvetlov
Copy link
Member Author

What code should read the config?

@webknjaz
Copy link
Member

969dc56#diff-58a40afaf674c2840d1dbacfc236d17cR26

@asvetlov
Copy link
Member Author

Well, I hope we'll never touch the script anymore.
I respect your striving to have all such config params in single place but please let's keep the script simple.
We can return to the subject on next CHANGES renaming, sure.

@aio-libs-bot aio-libs-bot mentioned this issue Nov 19, 2018
Closed
@aio-libs-bot aio-libs-bot mentioned this issue Jan 1, 2019
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvetlov @webknjaz