Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the HttpVersion on the request level #3474

Closed
Den1al opened this issue Jan 1, 2019 · 3 comments
Closed

Change the HttpVersion on the request level #3474

Den1al opened this issue Jan 1, 2019 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement

Comments

@Den1al
Copy link

Den1al commented Jan 1, 2019

Long story short

Currently, the only way to change the "HttpVersion" of a request is on the ClientSession level. However, often (in my experience) changing the "HttpVersion" on the request level is desired.

Expected behaviour

I expect to be able to pass the version parameter to the session.get (or session.request in general) so I can change the http version on the request level.

Actual behaviour

The only way to change the version parameter is via the ClientSession object. A workaround I do now, (which is a bad practice) is to change the "private" class parameter called _version in the ClientSession instance.

@aio-libs-bot
Copy link

GitMate.io thinks the contributor most likely able to help you is @asvetlov.

Possibly related issues are #242 (Request's storage), #2130 (Rename changes to CHANGES ), #2024 (Preparing a websocket from a low-level-server request fails), #875 (Improve Request.repr), and #2998 (Change appveyor account).

@aio-libs-bot aio-libs-bot added documentation Improvements or additions to documentation enhancement labels Jan 1, 2019
@kxepal
Copy link
Member

kxepal commented Jan 1, 2019

Why do you want that?

@asvetlov
Copy link
Member

No anwer :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement
Projects
None yet
Development

No branches or pull requests

4 participants