-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge basic tutorial from docs into basic hands on #245
Merge basic tutorial from docs into basic hands on #245
Conversation
thanks @mbercx, I've also linked a number of issues that I think this should close, but maybe have a check if this is the case |
Co-authored-by: Chris Sewell <[email protected]>
Thanks @chrisjsewell for the review! I've applied all of your suggestions, save for some unresolved conversations. @ltalirz or @giovannipizzi: Considering the large number of changes, it would be great if you could have a look at the whole section and see if you agree with the content and structure. |
You still haven't figured out how to run pre-commit though have you 😜 |
@mbercx Thanks a lot for all this work! I will first need to go through the plugins/code setup howtos before going through this section in-depth, but let me give some initial feedback already now:
Note: You might want to add a comment in the "AiiDA basics" section to mention that it is taken from the basic aiida tutorial (even if just for us to remember in the future)
I agree that this information can be moved to data/querying, but in that case please move it there.
One thing I am missing is the interactive provenance exploration using the Materials Cloud provenance explorer.
Ideally it would be the same computer (unless we can think of an educational reason to create a second one. It might confuse participants ("do I need to create a new computer for every code?")). If we don't manage to change it, it's ok to leave it.
I don't consider it mandatory to be 100% consistent on this.
If you know where to place them, please do. I fully agree. |
P.S. Just to provide some context as to the previous structure of the QE example: Since the basic tutorial from the aiida-core docs now manages to introduce all these concepts in a straightforward manner, there is really no compelling reason anymore to keep this order, and so for the "QE example" I am all for integrating the 'data analysis' into the 'running computations' part wherever possible. |
List of things to check:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed with @mbercx I think this is good to go - remaining items on the checklist can be handled in a separate PR
I opened #248 to keep track of the remaining items for the basics section. |
Fixes #238
Fixes #242
This PR is a rather large revamp of the AiiDA basics section of the tutorial, which now starts from the "basic tutorial" from the new AiiDA documentation. In order to still introduce the data types required for the rest of the tutorial, the tutorial continues along the lines of the previous version, but the sections have been restructured significantly, as splitting them up in verdi CLI and verdi shell did not make any sense after we already combine the two in the first part of the section.
My idea was to sort the content by data type and then discuss the the PwCalculation process, its inputs and then outputs in that order. I've tried my best to avoid too much repetition, or added words like "remember that..." to indicate that they've seen this previously. I'm still going to have another pass at this tomorrow with a clearer head, but feel free to already have a look and give suggestions.
Some notes:
Some open issues/questions:
tutor
. In the "running computations" hands on, a computer with labellocalhost
is configured. Should we only configure one computer, or is it fine to keep both so they see multiple computers when they executeverdi computer list
?<IDENTIFIER>
versus actually providing the PK/UUID in the CLI command/code snippet.