-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show visual indication of the selected namespace and context #107
Conversation
This should work for most users anyway.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
When using `kubens` with `fzf` there's no visual indication of the selected namespace. That's becuase fzf is considered a non-interactive tty, so there's no color on the output. This PR aims to fix that by creating a specific flag, that gets set every time we call kubens with fzf
0a8e32b
to
12bf405
Compare
I'm currently -1 for introducing yet another variable, some reasons:
Simplest (but hacky) way I'm imagining we can solve this:
thoughts? |
Please review #109. The |
When using
kubens
withfzf
there's no visual indication of the selected namespace and context.That's because
fzf
is considered a non-interactive tty, so there's no colour on the output.This PR aims to fix that by creating a specific flag, that gets set every time we call kubens with fzf.
Fixes #98 and #89