Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must show colors for the current context in fzf mode #89

Closed
ahmetb opened this issue Oct 9, 2018 · 0 comments
Closed

Must show colors for the current context in fzf mode #89

ahmetb opened this issue Oct 9, 2018 · 0 comments
Labels
Bug 🙏Help Wanted

Comments

@ahmetb
Copy link
Owner

ahmetb commented Oct 9, 2018

When fzf installed, kubectx v0.6.1 is not showing any colors about current context.

I think we need something like KUBECTX_FORCE_COLOR while invoking fzf. Need to investigate whether --ansi flag on fzf will be a problem or not.
@FabioAntunes FabioAntunes mentioned this issue Dec 22, 2018
Closed
@ahmetb ahmetb mentioned this issue Dec 22, 2018
Merged
ahmetb added a commit that referenced this issue Dec 29, 2018
@ahmetb
Show color in interactive mode (#109)
b584d14 
This patch introduces an internal _KUBECTX_FORCE_COLOR environment variable
that overrides color output decision.

With this, fzf output shows the color indicators for ctx/ns and choosing the
option with the color works without any extra handling.

Fixes #89.
Fixes #98.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🙏Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahmetb