Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with the latest Tauri release #14

Merged
merged 7 commits into from
Sep 11, 2023
Merged

fix: compatibility with the latest Tauri release #14

merged 7 commits into from
Sep 11, 2023

Conversation

flerouwu
Copy link
Contributor

@flerouwu flerouwu commented Sep 8, 2023

Issue

Currently, tauri-controls doesn't work with the latest versions of @tauri-apps/plugin-window due to a refactor..

Links

Solution

Bumping each package's version of @tauri-apps/plugin-window to 2.0.0-alpha.1, as well as modifying code to adjust for the refactor has fixed this issue.

Notes

  • The Solid and Vue packages have had their ref() and createSignal() function calls removed respectively, as they are no longer required.

@agmmnn
Copy link
Owner

agmmnn commented Sep 8, 2023

Thanks for the PR. 🙏

Currently, tauri-controls doesn't work with the latest versions of @tauri-apps/plugin-window due to a refactor..

Yes, I was planning to work on it, but I was on vacation and just got back.

@flerouwu
Copy link
Contributor Author

flerouwu commented Sep 8, 2023

Thanks for the PR. 🙏

Currently, tauri-controls doesn't work with the latest versions of @tauri-apps/plugin-window due to a refactor..

Yes, I was planning to work on it, but I was on vacation and just got back.

All good! Hope you enjoyed your vacation!

Hope this PR helps. Feel free to take your time reviewing it.

@agmmnn
Copy link
Owner

agmmnn commented Sep 9, 2023

I'll look into it, but I'm stuck with this issue on Windows. I can only move forward if this problem is fixed. :/

tauri-apps/tauri#7784
https://discord.com/channels/616186924390023171/1149396631070982274

@agmmnn
Copy link
Owner

agmmnn commented Sep 9, 2023

Related issues: #13

@agmmnn
Copy link
Owner

agmmnn commented Sep 11, 2023

I'll look into it, but I'm stuck with this issue on Windows. I can only move forward if this problem is fixed. :/

tauri-apps/tauri#7784 discord.com/channels/616186924390023171/1149396631070982274

tauri-apps/tauri#7801
https://github.com/tauri-apps/tauri/releases/tag/tauri-v2.0.0-alpha.14

@agmmnn agmmnn changed the title bump versions of @tauri-apps/plugin-window for compatibility with latest release fix: compatibility with the latest Tauri release Sep 11, 2023
@agmmnn agmmnn merged commit d8ae32b into agmmnn:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants