Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of official Rapsberry Pi touchscreen (kernel 4.1.8) #2

Closed
wants to merge 4 commits into from
Closed

Add support of official Rapsberry Pi touchscreen (kernel 4.1.8) #2

wants to merge 4 commits into from

Conversation

ThomArmax
Copy link

I have added the support of the official rapsberry pi touchscreen by changing PREFERRED_VERSION_linux-raspberrypi to 4.1.% and adding the associated kernel recipe.

I'm not shure it is the best way to do it, I'm quite new in Yocto and BSP dev.

@agherzan
Copy link
Owner

agherzan commented Oct 3, 2015

As well, if I don't ask too much, could you please read and follow these (http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines) guidelines for commit log?

Thanks a lot for your contribution.

@ThomArmax
Copy link
Author

Hi @agherzan ,
So what's the best way to do it (I'm new in open source contribution, git, and yocto/kernel dev)? Do I have to create a new pull request with clean commits (by a reset of my master) ?
Do you think a solution for

This won't work on other intermediate versions and implementing a way to handle it thick defeats the purpose a little bit. So I'm wondering if using only the default rpi kernel version would be the right way to do in order to avoid complexity.

could be to remove the kernel 3.18 and only keep 4.1 version ? This should remove all the complexity.

Thanks by advance

@agherzan
Copy link
Owner

Hi @ThomArmax . I put together a cleanup patch series. Could you please test the screen on them? The branch is ag_k4 on github here.

@ThomArmax
Copy link
Author

Hi @agherzan , ok thanks. I will test that this evening

@ThomArmax
Copy link
Author

The screen is recognised and seems to works, but the display is reversed.
I think it's beacause of the missing rpi-ft5406-overlay.dtb in overlays

@agherzan
Copy link
Owner

I added in the branch a commit for all the overlays. Could you please
retest now? Make sure you actually activate the overlay in config.txt

Andrei Gherzan

On Thu, Oct 22, 2015 at 7:01 PM, Thomas COIN [email protected]
wrote:

The screen is recognised and seems to works, but the display is reversed.
I think it's beacause of the missing rpi-ft5406-overlay.dtb in overlays

—
Reply to this email directly or view it on GitHub
#2 (comment)
.

@ThomArmax
Copy link
Author

I still have the same issue, even by adding dtoverlay=rpi-ft5406 in my config.txt.
I've read an article (https://www.raspberrypi.org/forums/viewtopic.php?f=108&t=121263) which says :

The Big Problem with all earliest Display Cases is that the Cable-Outputs are on the wrong side, because all manufactures had build their Cases with the 'wrong' Rotation.
Last Week the Rotation changed in Firmware so its now 180° upside down... (i know it was before flipped and now correct, but that doesnt change the Case-Problem)
I think its better to wait a little bit till new Versions of the Display-Cases will arrive

Because I bought the screen and its case in the first days, I have this issue. The kernel rev I used in my meta was 'not fixed' with the screen rotation so it works fine on my branch. Since your kernel rev in your branch is up-to-date I'm faced to this issue, which actually is not.

So I think we can say thats ok on your branch, and on my side, I've to find a solution like https://github.com/remonlam/rpi-touch-display-fix

Thanks.

@agherzan
Copy link
Owner

Is the touchscreen working too? With or without the overlayer?

@ThomArmax
Copy link
Author

I've not tried yet, a lot of work those days. I'll check that as soon as possible.

@agherzan
Copy link
Owner

Thank you Thomas.

@ThomArmax
Copy link
Author

Hi @agherzan ,
I'm glad to tell you the touchscreen is working. Test conditions :

  • Image : qt5-image-demo (meta-embarcados)
  • Branch : ag_k4
  • config.txt : dtoverlay=rpi-ft5406
  • Application launched: /usr/share/qt5everywheredemo-1.0/QtDemo -platform eglfs

If you don't enable the rpi-ft5406 overlay, the screen works but not the touchscreen

@agherzan
Copy link
Owner

Good news @ThomArmax . All we have to do now is figure out how to manage the different dtbs per kernel version. Cause for example rpi-ft5406 is only available in 4.1.x so adding it unconditionally will break older kernels.

@agherzan agherzan closed this Oct 27, 2015
Minipada pushed a commit to Minipada/meta-raspberrypi that referenced this pull request Oct 27, 2017
feat: enables videocore on the rpi-cm3-64 (agherzan#2)
e8a3b08
Minipada pushed a commit to Minipada/meta-raspberrypi that referenced this pull request Oct 27, 2017
@thiagodefreitas
feat: enables videocore on the rpi-cm3-64 (agherzan#2)
f85ef46
agherzan pushed a commit that referenced this pull request Mar 23, 2018
@hhromic @agherzan
gstreamer1.0-omx: refresh and clean-up patches
415c199 
fixes:

    WARNING: gstreamer1.0-omx-1.12.4-r0 do_patch:
    Some of the context lines in patches were ignored. This can lead to incorrectly applied patches.
    The context lines in the patches can be updated with devtool:

        devtool modify <recipe>
        devtool finish --force-patch-refresh <recipe> <layer_path>

    Then the updated patches and the source tree (in devtool's workspace)
    should be reviewed to make sure the patches apply in the correct place
    and don't introduce duplicate lines (which can, and does happen
    when some of the context is ignored). Further information:
    http://lists.openembedded.org/pipermail/openembedded-core/2018-March/148675.html
    https://bugzilla.yoctoproject.org/show_bug.cgi?id=10450
    Details:
    Applying patch 0001-config-files-path.patch
    patching file config/bellagio/gstomx.conf
    Hunk #1 succeeded at 1 with fuzz 2.
    Hunk #2 succeeded at 9 with fuzz 2.
    patching file config/rpi/gstomx.conf
    Hunk #8 succeeded at 63 with fuzz 2.
    Hunk #10 succeeded at 82 with fuzz 2.
    Hunk #11 succeeded at 92 with fuzz 2.

    Now at patch 0001-config-files-path.patch

deleted obsolete `gstreamer1.0-omx` directory with duplicated patches that are also in `gstreamer1.0-omx-1.12`.
made file naming for `gstreamer1.0-omx_%.bbappend` consistent with the rest of the layer recipes.

Signed-off-by: Hugo Hromic <[email protected]>
agherzan pushed a commit that referenced this pull request Jun 27, 2018
@hhromic @agherzan
omxplayer: refresh and clean-up patches
2b35265 
fixes:

    WARNING: omxplayer-git-r4 do_patch:

    Applying patch 0003-Remove-strip-step-in-Makefile.patch
    patching file Makefile.ffmpeg
    Hunk #1 succeeded at 241 with fuzz 2 (offset -2 lines).
    Hunk #2 succeeded at 255 (offset -2 lines).

    Applying patch fix-tar-command-with-DIST.patch
    patching file Makefile
    Hunk #1 succeeded at 89 with fuzz 2 (offset 18 lines).

    Applying patch use-native-pkg-config.patch
    patching file Makefile.ffmpeg
    Hunk #1 succeeded at 245 with fuzz 1.

Signed-off-by: Hugo Hromic <[email protected]>
@Metatron2k2 Metatron2k2 mentioned this pull request Jul 6, 2021
Closed
@BassemMohsen BassemMohsen mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomArmax @agherzan