Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Tree Binary management for different kernels and machine configurations #10

Closed
toolmmy opened this issue Mar 15, 2016 · 3 comments

Comments

@toolmmy
Copy link
Contributor

toolmmy commented Mar 15, 2016

There are currently multiple issues regarding the device tree binary handling. Currently all dtb's are specified in the rpi-base.inc. But this causes multiple isses by different kernel recipes. For example the Kernel 3.18 doesn't provide the bcm2710-rpi-3-b.dtb

| make[3]: *** No rule to make target 'arch/arm/boot/dts/bcm2710-rpi-3-b.dtb'. Stop. | make[2]: *** [bcm2710-rpi-3-b.dtb] Error 2 | make[1]: *** [sub-make] Error 2 | make: *** [__sub-make] Error 2 | ERROR: oe_runmake failed | ERROR: Function failed: do_compile (log file is located at /builds/raspberrypi3/tmp/work/raspberrypi2-poky-linux-gnueabi/linux-raspberrypi/1_3.18.16+gitAUTOINC+1bb18c8f72-r0/temp/log.do_compile.24045)

Same issue applies to the pitft22-overlay.dtb. This dtb is currently handled for each kernel version explicitly. New kernel version (such as linux-raspberrypi_4.4.bb) needs to add the patch-file again.
| NOTE: make -j 8 overlays/pitft22-overlay.dtb | make[3]: *** No rule to make target 'arch/arm/boot/dts/overlays/pitft22-overlay.dtb'. Stop. | make[2]: *** [overlays/pitft22-overlay.dtb] Error 2 | make[1]: *** [sub-make] Error 2 | make: *** [__sub-make] Error 2 | ERROR: oe_runmake failed | ERROR: Function failed: do_compile (log file is located at /storage/builds/raspberrypi3/tmp/work/raspberrypi2-poky-linux-gnueabi/linux-raspberrypi/1_4.4.3+gitAUTOINC+a2c8f5b320-r0/temp/log.do_compile.27266)

So in this case I would suggest a machine specific devite-tree handling

@toolmmy
Copy link
Contributor Author

toolmmy commented Mar 20, 2016

@agherzan please checkout the changes made in here https://github.com/toolmmy/meta-raspberrypi/commit/cddd262b5904d464e6a751391edc7b41fc375907. If they are suitable for you I would create a pull request.

@toolmmy
Copy link
Contributor Author

toolmmy commented Apr 2, 2016

Can be closed due to commit 75efa69

@toolmmy toolmmy closed this as completed Apr 2, 2016
@agherzan
Copy link
Owner

agherzan commented Apr 4, 2016

Thanks @toolmmy

agherzan pushed a commit that referenced this issue Mar 23, 2018
fixes:

    WARNING: gstreamer1.0-omx-1.12.4-r0 do_patch:
    Some of the context lines in patches were ignored. This can lead to incorrectly applied patches.
    The context lines in the patches can be updated with devtool:

        devtool modify <recipe>
        devtool finish --force-patch-refresh <recipe> <layer_path>

    Then the updated patches and the source tree (in devtool's workspace)
    should be reviewed to make sure the patches apply in the correct place
    and don't introduce duplicate lines (which can, and does happen
    when some of the context is ignored). Further information:
    http://lists.openembedded.org/pipermail/openembedded-core/2018-March/148675.html
    https://bugzilla.yoctoproject.org/show_bug.cgi?id=10450
    Details:
    Applying patch 0001-config-files-path.patch
    patching file config/bellagio/gstomx.conf
    Hunk #1 succeeded at 1 with fuzz 2.
    Hunk #2 succeeded at 9 with fuzz 2.
    patching file config/rpi/gstomx.conf
    Hunk #8 succeeded at 63 with fuzz 2.
    Hunk #10 succeeded at 82 with fuzz 2.
    Hunk #11 succeeded at 92 with fuzz 2.

    Now at patch 0001-config-files-path.patch

deleted obsolete `gstreamer1.0-omx` directory with duplicated patches that are also in `gstreamer1.0-omx-1.12`.
made file naming for `gstreamer1.0-omx_%.bbappend` consistent with the rest of the layer recipes.

Signed-off-by: Hugo Hromic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants