Additional LxLy Tests #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praetoriansentry
commented
Mar 3, 2025
Comment on lines
+79
to
+91
| | Variable | Purpose | | ||
| |--------------------+--------------------------------------------------------------------| | ||
| | RPC_URL | A generic JSON RPC URL for tests that do not require L1/L2 context | | ||
| | L1_RPC_URL | An RPC URL that serves as the L1 for some rollup or validium | | ||
| | L2_RPC_URL | An RPC URL for a rollup that's anchored on L1 | | ||
| | PRIVATE_KEY | A private key that's funded for RPC_URL | | ||
| | L1_PRIVATE_KEY | A private key that's funded for L1_RPC_URL | | ||
| | L2_PRIVATE_KEY | A private key that's funded for L2_RPC_URL | | ||
| | SEQUENCER_RPC_URL | An RPC URL that's directly connected to a sequencer | | ||
| | GAS_TOKEN_ADDR | The L1 address of a custom gas token | | ||
| | BRIDGE_SERVICE_URL | The URL of the bridge service used for claiming deposits | | ||
| | L1_BRIDGE_ADDR | The address of the bridge on L1 | | ||
| | L2_BRIDGE_ADDR | The address of the bridge on L2 | |
There was a problem hiding this comment.
fyi @rebelArtists / @leovct I reviewed the current tests and to define what looks like the common environment variables at this point. What do you guys think about this. It leaves out some stuff, but I think it would cover a lot of common cases
leovct
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Also, include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)