Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enterVR: reject promise if xr.requestSession fails #5382

Merged
merged 1 commit into from
Nov 14, 2023
+1 −1
Merged

enterVR: reject promise if xr.requestSession fails #5382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
enterVR: reject promise if xr.requestSession fails
@JL-Vidinoti
JL-Vidinoti committed Nov 14, 2023
commit be6944dd5a8a813773f6b70a97cff1b1199d80b7
2 changes: 1 addition & 1 deletion src/core/scene/a-scene.js
View file
Original file line number Diff line number Diff line change
@@ -308,7 +308,7 @@ class AScene extends AEntity {
function requestFail (error) {
var useAR = xrMode === 'immersive-ar';
var mode = useAR ? 'AR' : 'VR';
throw new Error('Failed to enter ' + mode + ' mode (`requestSession`) ' + error);
reject(new Error('Failed to enter ' + mode + ' mode (`requestSession`)', { cause: error }));
}
);
});