enterVR: reject promise if xr.requestSession fails #5382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Just curious. In what context did you find this an issue? Might inform other decisions. Thanks! |
|
Congrats on your first contribution! |
|
I discovered the issue while doing some tests in AR. When denying the Chrome permission, the AR mode was not starting and no error message was displayed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When calling enterVR (or enterAR), the function
navigator.xr.requestSessionmay fail (e.g. if the user denied the required permissions). In this case, an error is thrown but it is impossible to catch it.Changes proposed: