Detect both deprecated and 1.0 WebVR API support #1374
Conversation
| // Webvr polyfill configuration. | ||
| window.hasNonPolyfillWebVRSupport = !!navigator.getVRDevices; | ||
| // WebVR polyfill configuration. | ||
| window.hasNonPolyfillWebVRSupport = !!navigator.getVRDevices || !!navigator.getVRDevices; |
There was a problem hiding this comment.
My eyes must be missing something, but these look the same!
|
@cvan Does this look good to you? |
|
@mkeblx Can you squash your commits? |
|
I needed this to get working in GearVR browser with 1.0 API. But saw #1132 so don't know if have plans for adding 1.0 support in a different fashion. |
|
Just tested out GitHub squash merging. What's our opinion on that? |
|
I wanted @cvan feedback. I'm not sure this should have landed. We have no support for WebVR 1.0 in a-frame yet. I believe the value of hasNonPolyfillWebVRSupport is not correct after this patch. |
|
My bad, for some reason I thought the second comment was cvan's. |
|
I'm actually working on this in #1132... but thanks. |
|
@cvan this PR has been merged. Are you ok with this change or do you want to handle it differently? |
|
No, it's fine. But have to change a few other things. Finishing up my PR as we speak. |
Description:
-Naming update for WebVR 1.0 spec.
Changes proposed:
-Add check for new API method name for device querying.