Instructions for cardboard/landscape are missing when entering VR

[masom]

Description:
Instructions on rotating the device into landscape / into cardboard are now missing.

• A-Frame Version: master
• Platform/Device: Android, iOS

[dmarcos]

@cvan Anything in the top of your mind?

[cvan]

I haven't changed anything here yet. I am in #1132 but haven't touched it. I will investigate though.

[cvan]

Investigated this a bit and figured out a solution. A slight regression occurred (I think when the code was moved to a component): On iOS, the orientation modal doesn't appear until you rotate to landscape then rotate to portrait again. If the device is in portrait mode when VR mode is entered, the orientation modal doesn't show up. (In A-Frame 0.1.2, this works as expected.)

On Android, the orientation modal never shows up. There's an explicit check for only iOS; that's because it's assumed that iOS is the only mobile platform where the Fullscreen API isn't supported. This is mostly true (except Windows phone; I know, not a big deal here). Anyway, I have a fix for this too.

[ngokevin]

FWIW, it was working 2 weeks ago #1111

[cvan]

From what I found, it works only when you rotate to landscape immediately after entering VR mode then go back to portrait. Anyway, not sure which commit caused it; I didn't bother bisecting. But I've got a fix on the way, and it addresses a few other edge cases. And a few others, but I'm going to open up separate PRs for those.

[ngokevin]

Yeah, I think that's always been an issue. #879

[cvan]

Yeah, I think that's always been an issue. #879

ah, well then this bug is a dupe