[pull] main from elastic:main #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The new images have an updated gh binary which now requires setting the `GITHUB_REPO` env var, or calling `gh repo set-default`. I opted for the env var so that we didn't need to find a good time to execute the CLI (after the keys are in the env, but before all other user code) or worry about the logging. This also allows other users of our scripts to customize as makes sense without having to dive into a bunch of imperative shell code. Co-authored-by: kibanamachine <[email protected]>
This makes the add domain input in the Elastic crawler full width
## Summary In the new edit tags & edit assignees flyouts, I use `emotion` to add CSS that makes the flyout body 100% in height. PR #146212 introduces some changes where `emotion` runs in development mode. Before this PR it wasn't. This had as a result to break the styles in Cases. Our e2e tests did not catch it because all tests in CI run in production mode. ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Fixes #124946 ## Summary Takes a step toward optimising our migration paths by only reindexing (an expensive operation) when needed by checking whether the current SO mappings have "changed". By "changed" we mean that we have detected a new md5 checksum of any registered saved object type relative to the hashes we have stored. ## How to test These changes are constrained to the `model.ts`, a test was added for correctly detecting that mappings are the same during the `INIT` phase to send us down the correct migration path. Additionally, we have a new Jest integration test `skip_reindex.test.ts` that runs Kibana and inspects the logs for the expected model transitions. Everything else should remain the same. ## Happy path for skipping reindex ``` RUN INIT IF !versionMigrationIsComplete AND !kibana indexBelongsToLaterVersion AND !waitForMigrationCompletion AND mappingsAreUnchanged THEN the migration operations must target the existing .kibana_x.y.z_001 index RUN PREPARE_COMPATIBLE_MIGRATION (new state) we remove old version aliases (prevent old reads/writes), and set the current version alias (prevent old migrations) SKIP LEGACY_SET_WRITE_BLOCK SKIP ... SKIP SET_SOURCE_WRITE_BLOCK SKIP ... SKIP REFRESH_TARGET RUN OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT ... RUN MARK_VERSION_INDEX_READY DONE ``` ## Notes * This optimisation will only be triggered when there are no mappings changes AND we are upgrading to a new version. This does not cover all cases. In future we will make this more sophisticated by checking for incompatible changes to mappings and only reindexing when those occur. ## Related * #147503 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Gerard Soldevila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )