Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocommiting from CI #148066

Merged
merged 5 commits into from
Dec 23, 2022
Merged

Fix autocommiting from CI #148066

merged 5 commits into from
Dec 23, 2022

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Dec 23, 2022

The new images have an updated gh binary which now requires setting the GITHUB_REPO env var, or calling gh repo set-default. I opted for the env var so that we didn't need to find a good time to execute the CLI (after the keys are in the env, but before all other user code) or worry about the logging. This also allows other users of our scripts to customize as makes sense without having to dive into a bunch of imperative shell code.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Dec 23, 2022

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger changed the title require changes, make sure they work Fix autocommiting from CI Dec 23, 2022
@spalger spalger added the release_note:skip Skip the PR/issue when compiling release notes label Dec 23, 2022
@spalger spalger added Team:Operations Team label for Operations Team backport:all-open Backport to all branches that could still receive a release labels Dec 23, 2022
@spalger spalger marked this pull request as ready for review December 23, 2022 16:31
@spalger spalger requested a review from a team as a code owner December 23, 2022 16:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger merged commit 1b8ddc6 into elastic:main Dec 23, 2022
@spalger spalger deleted the test-auto-commit branch December 23, 2022 16:31
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 23, 2022
The new images have an updated gh binary which now requires setting the
`GITHUB_REPO` env var, or calling `gh repo set-default`. I opted for the
env var so that we didn't need to find a good time to execute the CLI
(after the keys are in the env, but before all other user code) or worry
about the logging. This also allows other users of our scripts to
customize as makes sense without having to dive into a bunch of
imperative shell code.

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 1b8ddc6)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 23, 2022
The new images have an updated gh binary which now requires setting the
`GITHUB_REPO` env var, or calling `gh repo set-default`. I opted for the
env var so that we didn't need to find a good time to execute the CLI
(after the keys are in the env, but before all other user code) or worry
about the logging. This also allows other users of our scripts to
customize as makes sense without having to dive into a bunch of
imperative shell code.

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 1b8ddc6)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.5
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 148066

Questions ?

Please refer to the Backport tool documentation

@spalger
Copy link
Contributor Author

spalger commented Dec 23, 2022

💚 All backports created successfully

Status Branch Result
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 23, 2022
# Backport

This will backport the following commits from `main` to `8.5`:
- [Fix autocommiting from CI
(#148066)](#148066)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Spencer","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-23T16:31:54Z","message":"Fix
autocommiting from CI (#148066)\n\nThe new images have an updated gh
binary which now requires setting the\r\n`GITHUB_REPO` env var, or
calling `gh repo set-default`. I opted for the\r\nenv var so that we
didn't need to find a good time to execute the CLI\r\n(after the keys
are in the env, but before all other user code) or worry\r\nabout the
logging. This also allows other users of our scripts to\r\ncustomize as
makes sense without having to dive into a bunch of\r\nimperative shell
code.\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"1b8ddc626765af542d4270bdb372a6e8bec14419","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.7.0"],"number":148066,"url":"https://github.com/elastic/kibana/pull/148066","mergeCommit":{"message":"Fix
autocommiting from CI (#148066)\n\nThe new images have an updated gh
binary which now requires setting the\r\n`GITHUB_REPO` env var, or
calling `gh repo set-default`. I opted for the\r\nenv var so that we
didn't need to find a good time to execute the CLI\r\n(after the keys
are in the env, but before all other user code) or worry\r\nabout the
logging. This also allows other users of our scripts to\r\ncustomize as
makes sense without having to dive into a bunch of\r\nimperative shell
code.\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"1b8ddc626765af542d4270bdb372a6e8bec14419"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148066","number":148066,"mergeCommit":{"message":"Fix
autocommiting from CI (#148066)\n\nThe new images have an updated gh
binary which now requires setting the\r\n`GITHUB_REPO` env var, or
calling `gh repo set-default`. I opted for the\r\nenv var so that we
didn't need to find a good time to execute the CLI\r\n(after the keys
are in the env, but before all other user code) or worry\r\nabout the
logging. This also allows other users of our scripts to\r\ncustomize as
makes sense without having to dive into a bunch of\r\nimperative shell
code.\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"1b8ddc626765af542d4270bdb372a6e8bec14419"}}]}]
BACKPORT-->

Co-authored-by: Spencer <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 23, 2022
# Backport

This will backport the following commits from `main` to `8.6`:
- [Fix autocommiting from CI
(#148066)](#148066)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Spencer","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-23T16:31:54Z","message":"Fix
autocommiting from CI (#148066)\n\nThe new images have an updated gh
binary which now requires setting the\r\n`GITHUB_REPO` env var, or
calling `gh repo set-default`. I opted for the\r\nenv var so that we
didn't need to find a good time to execute the CLI\r\n(after the keys
are in the env, but before all other user code) or worry\r\nabout the
logging. This also allows other users of our scripts to\r\ncustomize as
makes sense without having to dive into a bunch of\r\nimperative shell
code.\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"1b8ddc626765af542d4270bdb372a6e8bec14419","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.7.0"],"number":148066,"url":"https://github.com/elastic/kibana/pull/148066","mergeCommit":{"message":"Fix
autocommiting from CI (#148066)\n\nThe new images have an updated gh
binary which now requires setting the\r\n`GITHUB_REPO` env var, or
calling `gh repo set-default`. I opted for the\r\nenv var so that we
didn't need to find a good time to execute the CLI\r\n(after the keys
are in the env, but before all other user code) or worry\r\nabout the
logging. This also allows other users of our scripts to\r\ncustomize as
makes sense without having to dive into a bunch of\r\nimperative shell
code.\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"1b8ddc626765af542d4270bdb372a6e8bec14419"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148066","number":148066,"mergeCommit":{"message":"Fix
autocommiting from CI (#148066)\n\nThe new images have an updated gh
binary which now requires setting the\r\n`GITHUB_REPO` env var, or
calling `gh repo set-default`. I opted for the\r\nenv var so that we
didn't need to find a good time to execute the CLI\r\n(after the keys
are in the env, but before all other user code) or worry\r\nabout the
logging. This also allows other users of our scripts to\r\ncustomize as
makes sense without having to dive into a bunch of\r\nimperative shell
code.\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"1b8ddc626765af542d4270bdb372a6e8bec14419"}}]}]
BACKPORT-->

Co-authored-by: Spencer <[email protected]>
spalger pushed a commit that referenced this pull request Dec 23, 2022
# Backport

This will backport the following commits from `main` to `7.17`:
- [Fix autocommiting from CI
(#148066)](#148066)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Spencer","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-23T16:31:54Z","message":"Fix
autocommiting from CI (#148066)\n\nThe new images have an updated gh
binary which now requires setting the\r\n`GITHUB_REPO` env var, or
calling `gh repo set-default`. I opted for the\r\nenv var so that we
didn't need to find a good time to execute the CLI\r\n(after the keys
are in the env, but before all other user code) or worry\r\nabout the
logging. This also allows other users of our scripts to\r\ncustomize as
makes sense without having to dive into a bunch of\r\nimperative shell
code.\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"1b8ddc626765af542d4270bdb372a6e8bec14419","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.7.0"],"number":148066,"url":"https://github.com/elastic/kibana/pull/148066","mergeCommit":{"message":"Fix
autocommiting from CI (#148066)\n\nThe new images have an updated gh
binary which now requires setting the\r\n`GITHUB_REPO` env var, or
calling `gh repo set-default`. I opted for the\r\nenv var so that we
didn't need to find a good time to execute the CLI\r\n(after the keys
are in the env, but before all other user code) or worry\r\nabout the
logging. This also allows other users of our scripts to\r\ncustomize as
makes sense without having to dive into a bunch of\r\nimperative shell
code.\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"1b8ddc626765af542d4270bdb372a6e8bec14419"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148066","number":148066,"mergeCommit":{"message":"Fix
autocommiting from CI (#148066)\n\nThe new images have an updated gh
binary which now requires setting the\r\n`GITHUB_REPO` env var, or
calling `gh repo set-default`. I opted for the\r\nenv var so that we
didn't need to find a good time to execute the CLI\r\n(after the keys
are in the env, but before all other user code) or worry\r\nabout the
logging. This also allows other users of our scripts to\r\ncustomize as
makes sense without having to dive into a bunch of\r\nimperative shell
code.\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"1b8ddc626765af542d4270bdb372a6e8bec14419"}},{"url":"https://github.com/elastic/kibana/pull/148068","number":148068,"branch":"8.5","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/148069","number":148069,"branch":"8.6","state":"OPEN"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.9 v8.5.4 v8.6.0 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants