Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include search support for id, integer, and decimal fields. #226

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

aesmail
Copy link
Owner

@aesmail aesmail commented Nov 3, 2021

This PR adds support for searching against id, integer, and decimal fields.
Closes #134

@aesmail
Copy link
Owner Author

aesmail commented Nov 4, 2021

I just realized I might have done some extra work needlessly with this PR. I tried to add :integer and :decimal to search fields while they were already working apparently (casting to string). So this PR only adds the ability to search :id fields.

@ghenry
Copy link
Collaborator

ghenry commented Apr 12, 2023

Hi,

Would you be so kind as to do this again to the master branch?

Thanks,
Gavin.

@aesmail aesmail merged commit 545e0a5 into master Sep 28, 2023
11 checks passed
@aesmail aesmail deleted the allow-searching-numbers branch September 28, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE-REQUEST] Allow searching by id
2 participants