Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE-REQUEST] Allow searching by id #134

Closed
tensiondriven opened this issue Jul 22, 2020 · 1 comment · Fixed by #226
Closed

[FEATURE-REQUEST] Allow searching by id #134

tensiondriven opened this issue Jul 22, 2020 · 1 comment · Fixed by #226
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tensiondriven
Copy link
Contributor

Describe the problem you're proposing to solve

A common use case for an admin panel is to look up a record by id. I can add :id by implementing search_fields(), but according to https://github.com/aesmail/kaffy#search only string fields are supported.

Describe the solution you'd like
Support searching on numeric fields in addition to :string / :text.

Describe alternatives you've considered

Typing the id into the URL (assuming the resource id is the id i want)

Additional context

This is a brilliant piece of work and much needed in the Elixir/Phoenix community... and finally done right. Already useful, and, can't wait till its more fleshed out.

@tensiondriven tensiondriven added the enhancement New feature or request label Jul 22, 2020
@aesmail aesmail added this to the v0.9.1 milestone Jul 22, 2020
@aesmail
Copy link
Owner

aesmail commented Jul 22, 2020

I actually needed this today, a lot. It's safe to assume this is coming in the next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants