Do not run the app in debug mode by default #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not needed for running the suite and could have some unexpected implications (posed problems in the past). Still leave it accessible through the command line, just in case! Signed-off-by: Laurent Bonnans <[email protected]>
pattivacek
reviewed
Jun 19, 2019
| @@ -29,6 +29,8 @@ def arg_parser(): | |||
| default='127.0.0.1') | |||
| parser.add_argument('-P', '--port', help='The port to bind the app to', | |||
| type=int, default=8080) | |||
| parser.add_argument('--debug', help='Run the server in debug mode', | |||
| action='store_true') | |||
There was a problem hiding this comment.
Won't this still store debug=true by default?
There was a problem hiding this comment.
no, the opposite: https://docs.python.org/3/library/argparse.html#action
There was a problem hiding this comment.
Oops, now I understand. Good call.
pattivacek
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not needed for running the suite and could have some unexpected implications (posed problems in the past).
Still leave it accessible through the command line, just in case!