Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Remove Jenkins pipeline and a few references #1236

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Remove Jenkins pipeline and a few references #1236

merged 2 commits into from
Jun 19, 2019

Conversation

lbonn
Copy link
Contributor

@lbonn lbonn commented Jun 18, 2019

No description provided.

@lbonn lbonn requested review from pattivacek and eu-siemann June 18, 2019 14:41
@@ -28,7 +28,7 @@ HARDWARE_ID=test_primary_hardware_id

"$TTV_DIR/generator.py" --signature-encoding base64 -o vectors --cjson json-subset \
--ecu-identifier $ECU_SERIAL --hardware-id $HARDWARE_ID
# disable werkzeug debug pin which causes issues on Jenkins
# disable werkzeug debug pin which caused issues on Jenkins
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary? It's fine if you want to leave it, just checking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I ever knew what this werkzeug pin actually was. So we obviously don't need it and might as well keep it disabled :).

That said, there might be a cleaner way to do that in the tuf-test-vectors repo directly. I'll double check before merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pattivacek
pattivacek previously approved these changes Jun 18, 2019
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov-io
Copy link

codecov-io commented Jun 18, 2019

Codecov Report

Merging #1236 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1236      +/-   ##
==========================================
- Coverage   79.41%   79.18%   -0.23%     
==========================================
  Files         170      170              
  Lines       10123    10123              
==========================================
- Hits         8039     8016      -23     
- Misses       2084     2107      +23
Impacted Files Coverage Δ
src/libaktualizr-posix/ipuptanesecondary.cc 82.66% <0%> (-4%) ⬇️
src/libaktualizr/package_manager/ostreemanager.cc 75.42% <0%> (-1.7%) ⬇️
src/libaktualizr/storage/sql_utils.h 83.09% <0%> (-1.41%) ⬇️
src/aktualizr_primary/secondary.cc 86.3% <0%> (-1.37%) ⬇️
src/libaktualizr/storage/sqlstorage.cc 75.03% <0%> (-1.29%) ⬇️
src/libaktualizr/uptane/imagesrepository.cc 91.97% <0%> (-0.62%) ⬇️
src/libaktualizr/primary/sotauptaneclient.cc 91.71% <0%> (-0.61%) ⬇️
src/libaktualizr/storage/sqlstorage_base.cc 79.05% <0%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0b374...1477710. Read the comment docs.

pattivacek
pattivacek previously approved these changes Jun 19, 2019
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you want to wait to merge until you can bump the tuf-test-vectors version, or do want to just merge it now?

After a minor fix

Signed-off-by: Laurent Bonnans <[email protected]>
@lbonn
Copy link
Contributor Author

lbonn commented Jun 19, 2019

Looks good. Do you want to wait to merge until you can bump the tuf-test-vectors version, or do want to just merge it now?

Just pushed the bump in the spirit of limiting the number of trivial PRs :)

@lbonn lbonn merged commit 0f5d439 into master Jun 19, 2019
@lbonn lbonn deleted the rm/jenkins branch June 19, 2019 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants