-
Notifications
You must be signed in to change notification settings - Fork 61
Remove Jenkins pipeline and a few references #1236
Conversation
tests/run_vector_tests.sh
Outdated
@@ -28,7 +28,7 @@ HARDWARE_ID=test_primary_hardware_id | |||
|
|||
"$TTV_DIR/generator.py" --signature-encoding base64 -o vectors --cjson json-subset \ | |||
--ecu-identifier $ECU_SERIAL --hardware-id $HARDWARE_ID | |||
# disable werkzeug debug pin which causes issues on Jenkins | |||
# disable werkzeug debug pin which caused issues on Jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still necessary? It's fine if you want to leave it, just checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I ever knew what this werkzeug pin actually was. So we obviously don't need it and might as well keep it disabled :).
That said, there might be a cleaner way to do that in the tuf-test-vectors repo directly. I'll double check before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, opened advancedtelematic/tuf-test-vectors#55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Laurent Bonnans <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1236 +/- ##
==========================================
- Coverage 79.41% 79.18% -0.23%
==========================================
Files 170 170
Lines 10123 10123
==========================================
- Hits 8039 8016 -23
- Misses 2084 2107 +23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do you want to wait to merge until you can bump the tuf-test-vectors version, or do want to just merge it now?
After a minor fix Signed-off-by: Laurent Bonnans <[email protected]>
Just pushed the bump in the spirit of limiting the number of trivial PRs :) |
No description provided.