fetcher: urlencode target names

src/libaktualizr/uptane/fetcher.cc

@@ -113,8 +113,9 @@ bool Fetcher::fetchVerifyTarget(const Target& target) {
       bool retry = false;
       do {
         retry = false;
-        HttpResponse response = http->download(config.uptane.repo_server + "/targets/" + target.filename(),
-                                               DownloadHandler, &ds, ds.downloaded_length);
+        HttpResponse response =
+            http->download(config.uptane.repo_server + "/targets/" + Utils::urlEncode(target.filename()),
+                           DownloadHandler, &ds, ds.downloaded_length);
         if (!response.isOk() && !pause_) {
           fhandle->wabort();
           if (response.curl_code == CURLE_WRITE_ERROR) {

src/libaktualizr/utilities/utils.cc

@@ -657,6 +657,24 @@ void Utils::createDirectories(const boost::filesystem::path &path, mode_t mode)
   std::cout << "created: " << path.native() << "\n";
 }
 
+std::string Utils::urlEncode(const std::string &input) {
+  std::string res;
+
+  for (char c : input) {
+    if ((c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || (c >= '0' && c <= '9') || c == '-' || c == '.' ||
+        c == '_' || c == '~') {
+      res.push_back(c);
+    } else {
+      res.push_back('%');
+      auto nib = static_cast<char>(((c >> 4) & 0x0F));
+      res.push_back(static_cast<char>((nib < 10) ? nib + '0' : nib - 10 + 'A'));
+      nib = static_cast<char>(c & 0x0F);
+      res.push_back(static_cast<char>((nib < 10) ? nib + '0' : nib - 10 + 'A'));
+    }
+  }
+  return res;
+}
+
 class SafeTempRoot {
  public:
   SafeTempRoot(const SafeTempRoot &) = delete;

src/libaktualizr/utilities/utils.h

@@ -44,6 +44,7 @@ struct Utils {
   static void setSocketPort(sockaddr_storage *addr, in_port_t port);
   static std::vector<boost::filesystem::path> glob(const std::string &pat);
   static void createDirectories(const boost::filesystem::path &path, mode_t mode);
+  static std::string urlEncode(const std::string &input);
 };
 
 /**

src/libaktualizr/utilities/utils_test.cc

@@ -314,6 +314,8 @@ TEST(Utils, shell) {
   EXPECT_NE(statuscode, 0);
 }
 
+TEST(Utils, urlencode) { EXPECT_EQ(Utils::urlEncode("test! test@ test#"), "test%21%20test%40%20test%23"); }
+
 TEST(Utils, BasedPath) {
   BasedPath bp("a/test.xml");