This repository has been archived by the owner on May 21, 2024. It is now read-only.
fetcher: urlencode target names #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbonn
approved these changes
Nov 8, 2018
|
+1 for tests. |
Signed-off-by: Anton Gerasimov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
==========================================
+ Coverage 82.94% 82.96% +0.01%
==========================================
Files 187 187
Lines 13006 13019 +13
==========================================
+ Hits 10788 10801 +13
Misses 2218 2218
Continue to review full report at Codecov.
|
pattivacek
approved these changes
Nov 8, 2018
Signed-off-by: Anton Gerasimov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anton Gerasimov [email protected]
Needed for Sachertorte, but a good thing to have in general probably.