This repository has been archived by the owner on May 21, 2024. It is now read-only.
Feat/more clang tidy #1724
Merged
Feat/more clang tidy #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattivacek
force-pushed
the
feat/more-clang-tidy
branch
from
ddfc9e8 to
049a1fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
==========================================
+ Coverage 76.25% 76.44% +0.19%
==========================================
Files 185 185
Lines 13439 13404 -35
==========================================
- Hits 10248 10247 -1
+ Misses 3191 3157 -34
Continue to review full report at Codecov.
|
Not a lot of changes, but a few functions have been made const or static. Signed-off-by: Patrick Vacek <[email protected]>
Debian Buster (labeled as "testing") hasn't done anything special for us in a long time, and we tend to prefer Ubuntu as our baseline in practice anyway. Signed-off-by: Patrick Vacek <[email protected]>
Signed-off-by: Patrick Vacek <[email protected]>
This was easy to fix. Also added readability-redundant-declaration, but that didn't require any changes. Signed-off-by: Patrick Vacek <[email protected]>
Both were easy to fix. Signed-off-by: Patrick Vacek <[email protected]>
Again, easy to fix. Signed-off-by: Patrick Vacek <[email protected]>
Some annoying false positives but seems like a good thing to check for. Signed-off-by: Patrick Vacek <[email protected]>
No fixes required. Signed-off-by: Patrick Vacek <[email protected]>
Several items were deprecated or renamed anyway, so most of this was trivial. Signed-off-by: Patrick Vacek <[email protected]>
Signed-off-by: Patrick Vacek <[email protected]>
Many are redundant, and there are some false positives, but again, it seems like good stuff to be checking. Signed-off-by: Patrick Vacek <[email protected]>
Many were obsolete and most were duplicates of sensible defaults. I've left ones were I was more confident that the specified value was the right choice. readability-identifier-naming looks like a lot of unnecessary repitition but I don't want to accidentally break that. Signed-off-by: Patrick Vacek <[email protected]>
pattivacek
force-pushed
the
feat/more-clang-tidy
branch
from
049a1fb to
809e14e
Compare
eu-siemann
approved these changes
Jul 15, 2020
Either way is fine with me. Might depend on which one finishes the tests first. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've enabled more clang-tidy checks and cleaned up a lot of related cruft. Note that this currently includes #1720.