Clean up clang-tidy configuration options.

Many were obsolete and most were duplicates of sensible defaults. I've left ones were I was more confident that the specified value was the right choice. readability-identifier-naming looks like a lot of unnecessary repitition but I don't want to accidentally break that. Signed-off-by: Patrick Vacek <[email protected]>
advancedtelematic · Jul 14, 2020 · ddfc9e8 · ddfc9e8
1 parent 5173ae7
commit ddfc9e8
Showing 1 changed file with 13 additions and 79 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -20,97 +20,43 @@ CheckOptions:
   - key:             cppcoreguidelines-non-private-member-variables-in-classes.IgnorePublicMemberVariables
     value:           '1'
   - key:             cert-dcl59-cpp.HeaderFileExtensions
-    value:           h,hh,hpp,hxx
+    value:           h
   - key:             cert-err09-cpp.CheckThrowTemporaries
     value:           '1'
   - key:             cert-err61-cpp.CheckThrowTemporaries
     value:           '1'
-  - key:             cert-oop11-cpp.IncludeStyle
-    value:           llvm
   - key:             cppcoreguidelines-pro-type-member-init.IgnoreArrays
     value:           '0'
   - key:             google-build-namespaces.HeaderFileExtensions
-    value:           h,hh,hpp,hxx
+    value:           h
   - key:             google-global-names-in-headers.HeaderFileExtensions
     value:           h
   - key:             google-readability-braces-around-statements.ShortStatementLines
     value:           '1'
   - key:             google-readability-function-size.BranchThreshold
-    value:           '4294967295'
+    value:           '100'
   - key:             google-readability-function-size.LineThreshold
-    value:           '4294967295'
+    value:           '1000'
   - key:             google-readability-function-size.StatementThreshold
     value:           '800'
   - key:             google-readability-namespace-comments.ShortNamespaceLines
     value:           '10'
   - key:             google-readability-namespace-comments.SpacesBeforeComments
     value:           '2'
-  - key:             google-runtime-int.SignedTypePrefix
-    value:           int
-  - key:             google-runtime-int.TypeSuffix
-    value:           ''
-  - key:             google-runtime-int.UnsignedTypePrefix
-    value:           uint
-  - key:             google-runtime-references.WhiteListTypes
-    value:           ''
   - key:             llvm-header-guard.HeaderFileExtensions
-    value:           ',h,hh,hpp,hxx'
+    value:           h
   - key:             llvm-namespace-comment.ShortNamespaceLines
-    value:           '1'
+    value:           '10'
   - key:             llvm-namespace-comment.SpacesBeforeComments
-    value:           '1'
-  - key:             misc-argument-comment.StrictMode
-    value:           '0'
-  - key:             misc-assert-side-effect.AssertMacros
-    value:           assert
-  - key:             misc-assert-side-effect.CheckFunctionCalls
-    value:           '0'
-  - key:             misc-dangling-handle.HandleClasses
-    value:           'std::basic_string_view;std::experimental::basic_string_view'
+    value:           '2'
   - key:             misc-definitions-in-headers.HeaderFileExtensions
-    value:           ',h,hh,hpp,hxx'
+    value:           h
   - key:             misc-definitions-in-headers.UseHeaderFileExtension
     value:           '1'
-  - key:             misc-misplaced-widening-cast.CheckImplicitCasts
-    value:           '1'
-  - key:             misc-move-constructor-init.IncludeStyle
-    value:           llvm
   - key:             misc-non-private-member-variables-in-classes.IgnorePublicMemberVariables
     value:           '1'
-  - key:             misc-sizeof-expression.WarnOnSizeOfCompareToConstant
-    value:           '1'
-  - key:             misc-sizeof-expression.WarnOnSizeOfConstant
-    value:           '1'
-  - key:             misc-sizeof-expression.WarnOnSizeOfThis
-    value:           '1'
-  - key:             misc-string-constructor.LargeLengthThreshold
-    value:           '8388608'
-  - key:             misc-string-constructor.WarnOnLargeLength
-    value:           '1'
-  - key:             misc-suspicious-enum-usage.StrictMode
-    value:           '0'
-  - key:             misc-suspicious-missing-comma.MaxConcatenatedTokens
-    value:           '5'
-  - key:             misc-suspicious-missing-comma.RatioThreshold
-    value:           '0.200000'
-  - key:             misc-suspicious-missing-comma.SizeThreshold
-    value:           '5'
-  - key:             misc-suspicious-string-compare.StringCompareLikeFunctions
-    value:           ''
-  - key:             misc-suspicious-string-compare.WarnOnImplicitComparison
-    value:           '1'
-  - key:             misc-suspicious-string-compare.WarnOnLogicalNotComparison
-    value:           '0'
   - key:             misc-throw-by-value-catch-by-reference.CheckThrowTemporaries
     value:           '1'
-  - key:             modernize-loop-convert.MaxCopySize
-    value:           '16'
-  - key:             modernize-loop-convert.MinConfidence
-    value:           reasonable
-  - key:             modernize-loop-convert.NamingStyle
-    value:           CamelCase
-  - key:             modernize-replace-auto-ptr.IncludeStyle
-    value:           llvm
   - key:             modernize-use-auto.RemoveStars
     value:           '0'
   - key:             modernize-use-default-member-init.UseAssignment
@@ -119,26 +65,14 @@ CheckOptions:
     value:           '::std::vector;::std::list;::std::deque'
   - key:             modernize-use-emplace.SmartPointers
     value:           '::std::shared_ptr;::std::unique_ptr;::std::auto_ptr;::std::weak_ptr'
-  - key:             modernize-use-nullptr.NullMacros
-    value:           'NULL'
-  - key:             modernize-use-transparent-functors.SafeMode
-    value:           '0'
-  - key:             performance-faster-string-find.StringLikeClasses
-    value:           'std::basic_string'
-  - key:             performance-for-range-copy.WarnOnAllAutoCopies
-    value:           '0'
   - key:             performance-inefficient-string-concatenation.StrictMode
     value:           '0'
-  - key:             performance-type-promotion-in-math-fn.IncludeStyle
-    value:           llvm
-  - key:             performance-unnecessary-value-param.IncludeStyle
-    value:           llvm
   - key:             readability-braces-around-statements.ShortStatementLines
-    value:           '0'
+    value:           '1'
   - key:             readability-function-size.BranchThreshold
-    value:           '4294967295'
+    value:           '100'
   - key:             readability-function-size.LineThreshold
-    value:           '4294967295'
+    value:           '1000'
   - key:             readability-function-size.StatementThreshold
     value:           '800'
   - key:             readability-identifier-naming.AbstractClassCase
@@ -407,9 +341,9 @@ CheckOptions:
     value:           ''
   - key:             readability-identifier-naming.VirtualMethodSuffix
     value:           ''
-  - key:             readability-implicit-bool-cast.AllowConditionalIntegerCasts
+  - key:             readability-implicit-bool-conversion.AllowConditionalIntegerCasts
     value:           '0'
-  - key:             readability-implicit-bool-cast.AllowConditionalPointerCasts
+  - key:             readability-implicit-bool-conversion.AllowConditionalPointerCasts
     value:           '0'
   - key:             readability-simplify-boolean-expr.ChainedConditionalAssignment
     value:           '0'