Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create you move this repository into the openfortivpn organization? #1260

Closed
Neustradamus opened this issue Jan 2, 2025 · 23 comments
Closed

Comments

@Neustradamus
Copy link

Neustradamus commented Jan 2, 2025

Dear @adrienverge,

Thanks for your openfortivpn work!

Can you transfer this repository into the @openfortivpn organization?

GitHub adds redirections after transfer, no lost.

It will be really better for the current team to manage, etc.

Thanks in advance.

@Neustradamus Neustradamus changed the title Create an organization and transfer openfortivpn repository into? Create you move this repository into the openfortivpn organization? Jan 2, 2025
@DimitriPapadopoulos
Copy link
Collaborator

I am not the maintainer. Actually, I don't have much time any more to devote to openfortivpn.

@adrienverge
Copy link
Owner

Hello @Neustradamus, I understand that you would find it "really better", but I don't see the benefit of doing so. For info we already discussed this question with "the current team" some time ago.

@Neustradamus
Copy link
Author

Neustradamus commented Jan 2, 2025

@adrienverge: Only you can do it.
Example, you leave GitHub, the project is always blocked because of you.

The history, "Issues" and "PRs" are only here.

Your latest participation is old (2023-02-25):

If you do not transfer this repository, @DimitriPapadopoulos will need to fork this repository to have in @openfortivpn organization (the good place), and after he will need to contact GitHub to detach the fork from upstream but all forks are linked to this repository. So all people need to remove this personal fork and to create a new one, and need to create new issues too, etc..

Note: After a very long battle with GitHub and the new maintainer of one project, not easy, several years, I have realized the transfer of an important project from a died person (RIP) because the dead was announcement at several places in the past.

@DimitriPapadopoulos
Copy link
Collaborator

I do not intend to fork this repository and I don't have time to help much with openfortivpn any more.

With that said, I hear your concern. However, we have been looking for volunteers to help maintain the project, without success so far. That's the real problem.

@Neustradamus
Copy link
Author

@DimitriPapadopoulos: Changes have been integrated in upstream?

@DimitriPapadopoulos
Copy link
Collaborator

You're mistaken, there's no "upstream".

@Neustradamus
Copy link
Author

@adrienverge
Copy link
Owner

@Neustradamus my latest participation is not old, I periodically create new releases and follow everything that's happening here. With the huge help of @DimitriPapadopoulos, this repository is still alive.

But as Dimitri says: the real problem is the lack of volunteers to help maintaining the project. It's not about changing the repository URL, in my opinion.

@DimitriPapadopoulos
Copy link
Collaborator

To clarify, I don't have much time to devote to openfortivpn any more.

The real issue is finding an experienced volunteer to maintain openfortivpn and help with the necessary changes:

  • Use systemd-resolved when available, or better yet switch to vpnc-scripts to set routing and DNS parameters.
  • Support IPv6 - switching to vpnc-scripts would help considerably.
  • Address 2FA.
  • Work on compatibility with the FortiClient Endpoint Management Server (EMS).

@Neustradamus
Copy link
Author

@DimitriPapadopoulos: For the future of openfortivpn, it is better to move it into the @openfortivpn organization.

It is easy to manage a project in the @openfortivpn existing organization by @adrienverge and you.

If @adrienverge is not member, you must to add him here:

Do not forget to add you in public too.

In more, you can add new team members (volunteers) easily.

It is a needed step.

Thanks in advance.

@TwizzyDizzy
Copy link

TwizzyDizzy commented Jan 27, 2025

With that said, I hear your concern. However, we have been looking for volunteers to help maintain the project, without success so far. That's the real problem.

@DimitriPapadopoulos @adrienverge just an outside perspective, as I stumbled across this issue as I was searching something different: I smell very strong Jia Tan / XZ Tools vibes here. So I would very much suggest to not give in.

Indicators:

Cheers
Thomas

@DimitriPapadopoulos
Copy link
Collaborator

Actually, I and Adrien are the owners of https://github.com/openfortivpn 😄

@Neustradamus
Copy link
Author

Neustradamus commented Jan 27, 2025

@TwizzyDizzy: Thanks for your comment :)

Owners of @openfortivpn organization are @DimitriPapadopoulos and @adrienverge.

Do not hesitate to help to fix CVEs (vulnerabilities), to add new features (security and others), and to respect the GitHub TOS, to request new version (with improvements or/and security changes), etc.

You are welcome!

@TwizzyDizzy
Copy link

TwizzyDizzy commented Jan 27, 2025

Owners of https://github.com/openfortivpn organization are @DimitriPapadopoulos and @adrienverge

You could not have known this before @DimitriPapadopoulos wrote it, as the org members are private. In fact, you seem to have written something before and then deliberately edited your post (and deleted the edits) to repeat his statement.

No effort in this world will convince me, that you are not a malicious entity. Not, given your consistent way of behaviour and communication, often in lockstep with other dubious accounts.

This will be my last post in this issue. I have made my point.

Cheers
Thomas

@mrbaseman
Copy link
Collaborator

Thanks @TwizzyDizzy for the heads-up. I had the same impression, but didn't have the time yet to investigate in detail. As @adrienverge has pointed out, we do not see a benefit of moving the repository. Collaboration within the team works well (as far as our time allows to contribute). I can confirm that @adrienverge as the owner of the repository is quite responsive when releases need to be published. So, I do not see any danger that this project gets orphaned.

It's unfortunate that we do not have much time anymore to spend on the project, but especially with security related software, it is crucial to carefully review contributions. The xz tools case is a brilliant example for what can happen to a project if the maintainers become negligent in their decisions, for various reasons, and the whole open source community could learn a lot from that case. It's better to have the pull requests there, and review them when time permits, than pushing the project forward quickly and thereby running risk to get undermined.

I can try to devote a bit more time for the reviews in the near future. Contributions welcome, best is if they are of high quality, not too big changes at once, and therefore easy to review. :-)

Cheers, Martin

@Neustradamus
Copy link
Author

@TwizzyDizzy: Like you have blocked me, I have not received your message (thanks @mrbaseman for this message, I have discovered yours at the same time) and you will not received mines.

I am happy to answer/help you in all attacks against me.

About comment history changes, it is normal to delete, when we do a mistake in a word, etc.

It is important to contact authors to explain because a lot of people do not want to transfer one or more repositories because they think that old links will be lost and do not know that the manage is better in an organization.

I always explain to all, that there is no lost, GitHub adds automatically redirections from old place to new.

It is for this, that there are several projects with a good GitHub organization but repositories are not into.

It is important to inform and to train people and to specify the GitHub TOS:

For example: I will be happy if you can help me:

1/ To inform that XAMPP is unsecure, a lot of XAMPP Servers are online on the Internet.

2/ To request the support of "Salted Challenge Response Authentication Mechanism" (SCRAM-SHA-X/SCRAM-SHA-X-PLUS) to replace old and unsecure CRAM-MD5/DIGEST-MD5/LOGIN mechanismes:


@mrbaseman: Thanks for your answer :)

Yes, the XZ history is really important!
I have permit, indirectly, to discover the vulnerability, a chance!

I contact a lot of projects to create a new build, to have improvements because there are not a build since a long time or before an important OS release, for example Debian 13 "Trixie" arrives soon this year (2025) after Debian 12 "Bookworm" (2023) and before Debian 14 "Forky" (2027) and Debian 15 "Duke" (2029).

I contact a lot of projects to update libraries/softwares in source code too.

For example, I have requested a new Avahi version (and nss-mdns version too), the old maintainer has stopped and now the project is managed in a good GitHub organization, all redirections work...

Like others, I am very happy to help the @openfortivpn project!

@mrbaseman
Copy link
Collaborator

Thanks. I think we can close this discussion. We have expressed our attitude.

And to make the story complete, I'm the 3rd member of the openfortivpn org which was created years ago, if I'm not mistaken, just because it was necessary to provide a snap package. But that repo has been archived and is hundreds of commits behind upstream now.

openfortivpn has found its way into quite a number of distributions, and they all refer to the current repository in their documentation. Moving everything to a new place (even if github would add redirects) would leave a strange taste to all the users - unless it's widely announced in advance. I think, and I believe I'm speaking for the whole team, that it's not worth this effort.

@Neustradamus
Copy link
Author

@mrbaseman: I do not understand, you have closed my ticket but the repository has not been transfered into the @openfortivpn organization. Can you reopen it?

Very nice if there are more people in openfortivpn team.

I recall, no lost, a lot of projects have been moved from personal into a good organization.
There have been no lost, all old links are redirected to the good place (issues, PRs, comments, source, ...).

Of course, all rights are transfered too.

In this case, the first step has been done, the organization exists but main repository is not into.

Only @adrienverge can do this step.

From the GitHub documentation:

Transfer a repository:

Thanks in advance.

@Neustradamus
Copy link
Author

Important: There was no problem with all projects which have done it.

@adrienverge
Copy link
Owner

Hello @Neustradamus,

I followed all the multiple messages you posted, but it seems that you didn't really understood our concerns nor answer our questions.

@mrbaseman: I do not understand, you have closed my ticket but the repository has not been transfered into the @openfortivpn organization.

We've taken good note that you really want this to happen. But I feel that this GitHub issue is moving away from a constructive discussion.

@Neustradamus
Copy link
Author

@adrienverge: What questions are without answers?

@Neustradamus
Copy link
Author

2025-01-02: @adrienverge: You have done these comments:

1/ "I understand that you would find it "really better", but I don't see the benefit of doing so. For info we already discussed this question with "the current team" some time ago."
Here: #1260 (comment)

-> I have answered you: #1260 (comment)

In more, it is good to have talked with team previously.

2/ "@Neustradamus my latest participation is not old, I periodically create new releases and follow everything that's happening here. With the huge help of @DimitriPapadopoulos, this repository is still alive.

But as Dimitri says: the real problem is the lack of volunteers to help maintaining the project. It's not about changing the repository URL, in my opinion."

Here: #1260 (comment)

-> I have answered you:
#1260 (comment)

Of course, it is really good for the project that @DimitriPapadopoulos does a good work!

@DimitriPapadopoulos has done contributions in other projects, in the past, I have already thanked him for this work :)


People do not understand that the organization is empty (now the fork is archived after my initial request: https://github.com/openfortivpn/snap) and it will be really better to have all in one place instead of empty organization.
Better to manage the project: https://docs.github.com/organizations
Of course, it is better to have a good organization that a fake account, a lot of projects have not the good username.

I can specify you an example, it was a success but it was hard to solve the situation of libpng project, the original author is died (RIP Glenn Randers-Pehrson), and the new maintainer has done a detached fork but the code was duplicated in two repositories, and all people always contribute in original place, and create ticket too, and all forks, stars, watchers was linked to original place. After several contacts with GitHub, the main repository "upstream" has been transfered in the organization and now correctly used, and the detached fork has been renamed.

@adrienverge: I recall, it is only you who can do the transfer in the organization, @DimitriPapadopoulos or @mrbaseman can not do it.

Recall: No lost, all old links will be redirected.

You can re-read all my comments.

Hope that you will have more contributors after the transfer into the good @openfortivpn existing organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants