Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove test dependance on linting #217

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Conversation

adriangb
Copy link
Owner

@adriangb adriangb commented Mar 6, 2021

See thread in #208 (review)

Since we use GHA as a FOSS project, we really don't pay for usage. This will increase usage because tests will run even if linting fails, but will help PR feedback TAT because failed linting won't preclude getting test data back.

See thread in #208 (review)

Since we use GHA as a FOSS project, we really don't pay for usage. This will increase usage because tests will run even if linting fails, but will help PR feedback TAT because failed linting won't preclude getting test data back.
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

📝 Docs preview for commit 23132fe at: https://www.adriangb.com/scikeras/refs/pull/217/merge/

@adriangb adriangb merged commit d941d96 into master Mar 6, 2021
@adriangb adriangb deleted the adriangb-patch-1 branch March 6, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant