Skip to content

Commit

Permalink
MAINT: remove test dependance on linting
Browse files Browse the repository at this point in the history
See thread in #208 (review)

Since we use GHA as a FOSS project, we really don't pay for usage. This will increase usage because tests will run even if linting fails, but will help PR feedback TAT because failed linting won't preclude getting test data back.
  • Loading branch information
adriangb authored Mar 6, 2021
1 parent 57d1746 commit 23132fe
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
- uses: pre-commit/[email protected]

TestStable:
needs: Linting
name: Ubuntu / Python ${{ matrix.python-version }} / TensorFlow Stable / Scikit-Learn Stable
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -55,7 +54,6 @@ jobs:
- uses: codecov/codecov-action@v1

TestDev:
needs: Linting
name: Ubuntu / Python ${{ matrix.python-version }} / TensorFlow Nightly / Scikit-Learn Nightly
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -98,7 +96,6 @@ jobs:
- uses: codecov/codecov-action@v1

TestOldest:
needs: Linting
name: Ubuntu / Python ${{ matrix.python-version }} / TF ${{ matrix.tf-version }} / Scikit-Learn ${{ matrix.sklearn-version }}
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -135,7 +132,6 @@ jobs:
- uses: codecov/codecov-action@v1

TestOSs:
needs: Linting
name: ${{ matrix.os }} / Python ${{ matrix.python-version }} / TF Stable / Scikit-Learn Stable
runs-on: ${{ matrix.os }}-latest
strategy:
Expand Down

0 comments on commit 23132fe

Please sign in to comment.