-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to support stf repo and branch #112
Conversation
src/runaqa.ts
Outdated
@@ -86,6 +87,12 @@ export async function runaqaTest( | |||
myOutput += data.toString() | |||
} | |||
} | |||
|
|||
if (buildList === 'openjdk' && stfRepo && stfRepo.length !== 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SehrishHussain sorry, I may forget to mention that SFT repo is related with system tests, not openjdk tests. So please move this block to system tests check.
Line 63 in 7ffa6dc
if (buildList.includes('system')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sophia-guo does this line go like this:
if (buildList === 'aqa-systemtestRepo' && stfRepo && stfRepo.Length!==0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can simply add your change after
Line 66 in 7ffa6dc
} |
if (stfRepo && stfRepo.length !== 0) {
const repoBranch = parseRepoBranch(stfRepo)
process.env.STF_REPO = repoBranch[0]
process.env.STF_BRANCH = repoBranch[1]
}
@sophia-guo please check the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@smlambert can you review and approve please. TIA |
This supersedes #111 - so we will ask @akanbifatimah to close her PR for the same issue. |
This was approved but never merged (and now the branch contains conflicts that need to be resolved). @SehrishHussain - is it possible for you to resolve the conflicts? if resolved then @sophia-guo can you re-review and merge? if not resolved in the next couple of weeks, let's close it as stale |
@SehrishHussain & @sophia-guo - bump :-) |
Changed the corresponding files by adding environment variables is env.STF_REPO and env.STF_BRANCH.
Addressing issue: #109