Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to support stf repo and branch #109

Open
sophia-guo opened this issue Oct 12, 2021 · 6 comments
Open

Add option to support stf repo and branch #109

sophia-guo opened this issue Oct 12, 2021 · 6 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@sophia-guo
Copy link
Contributor

Currently run-aqa run system tests with latest STF.

It would be nice if we add option to support stf repo and branch so we can run system tests with specified stf version.

We could do this ether by passing the environment variable or adding the options. Adding the options would be more easy and clear. Similar to the PR #103. The environment variable is env.STF_REPO and env.STF_BRANCH.

@sophia-guo sophia-guo added the good first issue Good for newcomers label Oct 12, 2021
@akanbifatimah
Copy link

Hi, @sophia-guo i would like to take on this issue but want to know the basic skills et needed. Thank you

@akanbifatimah
Copy link

akanbifatimah commented Oct 13, 2021 via email

@smlambert
Copy link
Contributor

To address this issue, you can read the description and see that the advised solution asks you to follow the very same pattern as a previous issue (#92) which was solved by PR #103. The main difference is that it is for a different repo, so using different variables.

Changes to the same files are needed (including the yaml, javascript and typescript files):
https://github.com/adoptium/run-aqa/pull/103/files

@akanbifatimah
Copy link

akanbifatimah commented Oct 13, 2021 via email

@SehrishHussain
Copy link

@akanbifatimah hi, I went through your PR and left a comment. Let me know if you need help.

@SehrishHussain
Copy link

@smlambert can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants