-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to support stf repo and branch #109
Comments
Hi, @sophia-guo i would like to take on this issue but want to know the basic skills et needed. Thank you |
Thank you Sophia, However, you haven't answered my question about the basic
skill needed for this project.
I look forward to hearing from you.
Thank you.
warm regards,
Fatimah.
…On Tue, Oct 12, 2021 at 10:36 PM sophia-guo ***@***.***> wrote:
Assigned #109 <#109> to
@akanbifatimah <https://github.com/akanbifatimah>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#109 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR6DACDQI5U3ORHCZ7MLZKDUGSS65ANCNFSM5F3OPFXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
To address this issue, you can read the description and see that the advised solution asks you to follow the very same pattern as a previous issue (#92) which was solved by PR #103. The main difference is that it is for a different repo, so using different variables. Changes to the same files are needed (including the yaml, javascript and typescript files): |
Thank you very much for your guidance, I have started making some changes
however I am stuck at the aqa.ts file, there is a flag at the
error.message(it reads " object is of type unknown"
please how do I go about this, I have done "npm i" to but the reg flag is
still showing. I am looking forward to your assistance.
Warm regards.
…On Wed, Oct 13, 2021 at 7:47 PM Shelley Lambert ***@***.***> wrote:
To address this issue, you can read the description and see that the
advised solution asks you to follow the very same pattern as a previous
issue (#92 <#92>) which was
solved by PR #103 <#103>. The
main difference is that it is for a different repo, so using different
variables.
Changes to the same files are needed (including the yaml, javascript and
typescript files):
https://github.com/adoptium/run-aqa/pull/103/files
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR6DACEMZOFNMPTKUENA7SDUGXH3ZANCNFSM5F3OPFXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@akanbifatimah hi, I went through your PR and left a comment. Let me know if you need help. |
@smlambert can I work on this issue? |
Currently run-aqa run system tests with latest STF.
It would be nice if we add option to support stf repo and branch so we can run system tests with specified stf version.
We could do this ether by passing the environment variable or adding the options. Adding the options would be more easy and clear. Similar to the PR #103. The environment variable is env.STF_REPO and env.STF_BRANCH.
The text was updated successfully, but these errors were encountered: