Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ember v5 by addin @ember/string to peerDependencies #547

Merged
merged 9 commits into from
Nov 29, 2024
Merged

Support Ember v5 by addin @ember/string to peerDependencies #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
40fe84b
support Ember v4
jelhan Nov 19, 2024
f08602a
Merge branch 'require-node-18' into support-ember-v4
jelhan Nov 19, 2024
c2fa85a
@ember/string v4 is not compatible with Ember < 3.28
jelhan Nov 19, 2024
a3c70ec
add @ember/string as peer dep and run tests for Ember v5
jelhan Nov 26, 2024
2c48089
ember-resolver v8 is not compatible with Ember v5
jelhan Nov 26, 2024
8deec87
Merge remote-tracking branch 'origin/master' into support-ember-v4
jelhan Nov 29, 2024
9cc8469
downgrade to @ember/string v3
jelhan Nov 29, 2024
84e1ef4
Merge branch 'upgrade-with-ember-cli-4.12-blueprints' into support-em…
jelhan Nov 29, 2024
aca19c4
Merge remote-tracking branch 'origin/master' into support-ember-v4
jelhan Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ jobs:
try-scenario:
- ember-lts-3.28
- ember-lts-4.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelhan shouldn't we add the whole matrix of LTS versions in v4 and v5, like 4.4, 4.8, 5.4, 5.8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a realistic risk that it works for 4.12 and 5.12 but not for interim releases? CI minutes are free for open source projects on GitHub. But we should nevertheless review the value for each scenario as they have other trade-offs such as environmental impact.

Happy to add if you feel they provide real value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelhan very good question and considering ember-source had very little changes during v4 and v5, I guess answer is "no". It's more like a convention I've seen around in the ecosystem and been following for the addons I've tried to maintain.

- ember-lts-5.12
- ember-classic
# - ember-release
# - ember-beta
Expand Down
8 changes: 5 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,14 @@
"typescript": "^4.4.3",
"webpack": "^5.78.0"
},
"resolutions": {
"@babel/plugin-transform-modules-amd": "7.16.5"
},
"peerDependencies": {
"@ember/string": ">= 3.0.0",
"ember-source": ">= 3.28.0"
},
"resolutions": {
"@babel/plugin-transform-modules-amd": "7.16.5",
"@ember/string": "^4.0.0"
},
"engines": {
"node": "18.* || 20.* || >= 22"
},
Expand Down
9 changes: 9 additions & 0 deletions tests/dummy/config/ember-try.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ module.exports = async function () {
},
},
},
{
name: 'ember-lts-5.12',
npm: {
devDependencies: {
'ember-resolver': '^12.0.0',
'ember-source': '~5.12.0',
},
},
},
{
name: 'ember-release',
npm: {
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,6 +984,11 @@
dependencies:
ember-cli-babel "^7.26.6"

"@ember/string@^4.0.0":
version "4.0.0"
resolved "https://registry.yarnpkg.com/@ember/string/-/string-4.0.0.tgz#24fe5cda227c9e6634e6e0b550944a3a13437878"
integrity sha512-IMVyVE72twuAMSYcHzWSgtgYTtzlHlKSGW8vEbztnnmkU6uo7kVHmiqSN9R4RkBhzvh0VD4G76Eph+55t3iNIA==

"@ember/test-helpers@*":
version "4.0.4"
resolved "https://registry.yarnpkg.com/@ember/test-helpers/-/test-helpers-4.0.4.tgz#2ffb55c8438b8ba54ecd4f546059ba0166bc00f2"
Expand Down