Support Ember v5 by addin @ember/string to peerDependencies

[jelhan]

This is a breaking change as it is adding @ember/string as an additional peer dependency.

It included #550 which should be merged first.

[Windvis]

This is a breaking change as it is adding @ember/string as an additional peer dependency.

It's just a devDep at the moment, no? Also, @ember/string is a v2 addon so ember-auto-import v2 needs to be a dep I think?

[jelhan]

This is a breaking change as it is adding @ember/string as an additional peer dependency.

It's just a devDep at the moment, no? Also, @ember/string is a v2 addon so ember-auto-import v2 needs to be a dep I think?

You are right. It should have gone into peer dependencies. But somehow I missed it. No idea why the tests are passing anyways here but no in my app. Thanks a lot for careful review! Will fix it.

[jelhan]

I learned that there is a 2.0.0-beta.2 release, which supports Ember v5. The code is not in this repository. But it is available on NPM.

[jelhan]

The code for 2.0.0-beta.2 is in this repository. This is the tag.

Also 2.0.0-beta.2 is not compatible with Ember v5. It fails due to missing peer dependency on @ember/string.

[jelhan]

It should work. Also the added test scenario for Ember v5.12 passes. But I haven't tested in a real app yet.

[SergeAstapov]

as a follow up, we may bump support for 3.28+ which should simplify CI and should not affect many (if any) users as 3.20 -> 3.28 upgrade should be pretty simple

[jelhan]

I have done that in #549.

[jelhan]

It seems that some outdated dependencies weren't compatible with Ember v5 causing an error. After I merged in #550 it works fine. So let's land that upgrade first and than add the support for Ember v5 in the next step.

[SergeAstapov]

@jelhan mind to rebase this PR as #550 landed

[SergeAstapov]

@jelhan shouldn't we add the whole matrix of LTS versions in v4 and v5, like 4.4, 4.8, 5.4, 5.8?

[jelhan]

Is there a realistic risk that it works for 4.12 and 5.12 but not for interim releases? CI minutes are free for open source projects on GitHub. But we should nevertheless review the value for each scenario as they have other trade-offs such as environmental impact.

Happy to add if you feel they provide real value.

[SergeAstapov]

@jelhan very good question and considering ember-source had very little changes during v4 and v5, I guess answer is "no". It's more like a convention I've seen around in the ecosystem and been following for the addons I've tried to maintain.