Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: finish DateTimePicker and Calendar unit tests and VRTs #4962

Merged

Conversation

mizgaionutalexandru
Copy link
Contributor

@mizgaionutalexandru mizgaionutalexandru commented Nov 28, 2024

Description

This PR is a suite of finishing touches to the unit tests and VRTs of the Calendar and DateTimePicker components.
Also, the segments digits overflow logic was updated to a better UX (similar to the React Spectrum one).

Related issue(s)

Motivation and context

Better UX, DX and reliability.
Previous PR comments (link).

How has this been tested?

Mainly unit tests, other changes regarding to the Storybook UX can be observed there.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: cfcdd63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Copy link

github-actions bot commented Nov 28, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.98 0.99 0.98
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 252.307 kB 236.403 kB 217.391 kB 🏆
Scripts 62.035 kB 54.008 kB 52.703 kB 🏆
Stylesheet 54.172 kB 47.913 kB 30.216 kB 🏆
Document 6.24 kB 5.463 kB 🏆 5.51 kB
Font 126.906 kB 126.614 kB 126.614 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@mizgaionutalexandru mizgaionutalexandru marked this pull request as ready for review December 3, 2024 09:56
@mizgaionutalexandru mizgaionutalexandru requested a review from a team as a code owner December 3, 2024 09:56
@mizgaionutalexandru mizgaionutalexandru merged commit 002ed63 into feature/date-time-picker Dec 4, 2024
45 of 56 checks passed
@mizgaionutalexandru mizgaionutalexandru deleted the imizga/dtp-digits-overflow branch December 4, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants