fix(date-time-picker): ux bug fixes and improvements

[mizgaionutalexandru]

Description

Bugs fixed:

• deleting a year of a defined date makes the calendar no longer display the current one
• the calendar selects a year in the 1900s when the DTP has a year with 2- digits
• calendar's previous month button increases the year if the year is 1
• the year can't be deleted on safari without changing the focus back and forth on the year segment
• Bengali(India) year is not formatted on increment/decrement showing arabic numerals
• warnings were shown outside of dev-mode

UX improvements:

• Calendar month navigation buttons are now disabled when reaching the end of an era
• Calendar now always displays the initial month in a place where dates are available
• Calendar now closes when the disabled attribute is changed
• The year segment no longer has a min-width

Also, some methods were moved around inside the Calendar.ts source file to improve readability.

Related issue(s)

• [Feat]: Add Date Picker Pattern #2559
• [Feat]: Add Calendar pattern #2560

How has this been tested?

Unit tests.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• If my change required a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

[github-actions]

Branch preview

• Documentation Site
• Storybook

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• High Contrast Mode | Medium | LTR
• Spectrum | Lightest | Medium | LTR
• Spectrum | Lightest | Medium | RTL
• Spectrum | Lightest | Large | LTR
• Spectrum | Lightest | Large | RTL
• Spectrum | Light | Medium | LTR
• Spectrum | Light | Medium | RTL
• Spectrum | Light | Large | LTR
• Spectrum | Light | Large | RTL
• Spectrum | Dark | Medium | LTR
• Spectrum | Dark | Medium | RTL
• Spectrum | Dark | Large | LTR
• Spectrum | Dark | Large | RTL
• Spectrum | Darkest | Medium | LTR
• Spectrum | Darkest | Medium | RTL
• Spectrum | Darkest | Large | LTR
• Spectrum | Darkest | Large | RTL
• Express | Lightest | Medium | LTR
• Express | Lightest | Medium | RTL
• Express | Lightest | Large | LTR
• Express | Lightest | Large | RTL
• Express | Light | Medium | LTR
• Express | Light | Medium | RTL
• Express | Light | Large | LTR
• Express | Light | Large | RTL
• Express | Dark | Medium | LTR
• Express | Dark | Medium | RTL
• Express | Dark | Large | LTR
• Express | Dark | Large | RTL
• Express | Darkest | Medium | LTR
• Express | Darkest | Medium | RTL
• Express | Darkest | Large | LTR
• Express | Darkest | Large | RTL
• Spectrum-two | Light | Medium | LTR
• Spectrum-two | Light | Medium | RTL
• Spectrum-two | Light | Large | LTR
• Spectrum-two | Light | Large | RTL
• Spectrum-two | Dark | Medium | LTR
• Spectrum-two | Dark | Medium | RTL
• Spectrum-two | Dark | Large | LTR
• Spectrum-two | Dark | Large | RTL

[github-actions]

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category	Latest	Main	Branch
Total	228.438 kB	217.147 kB	217.132 kB 🏆
Scripts	57.688 kB	52.537 kB	52.50 kB 🏆
Stylesheet	34.596 kB	30.132 kB	30.102 kB 🏆
Document	6.239 kB	5.458 kB 🏆	5.496 kB
Font	126.898 kB	126.606 kB 🏆	126.615 kB

Request Count

Category	Latest	Main	Branch
Total	52	52	52
Scripts	41	41	41
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2