Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: bump minimun Node.JS version to Node 16.18 #523

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/semantic-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
if: "!contains(github.event.head_commit.message, '[skip ci]')"
steps:
- uses: actions/checkout@v3
- name: Use Node.js 14.x
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: '14.x'
node-version: '16.18'
- run: npm install
- run: git config --global user.email "[email protected]" && git config --global user.name "Test Build"
- run: npm test
Expand All @@ -26,10 +26,10 @@ jobs:
steps:
- run: git config --global core.autocrlf false
- uses: actions/checkout@v3
- name: Use Node.js 14.x
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: '14.x'
node-version: '16.18'
- run: npm install
- run: git config --global user.email "[email protected]" && git config --global user.name "Test Build"
- run: npm test
Expand All @@ -44,10 +44,10 @@ jobs:
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Use Node.js 14.x
- name: Use Node.js 16.18
uses: actions/setup-node@v3
with:
node-version: '14.x'
node-version: '16.18'
- run: npm install
- run: npm run semantic-release
env:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ These tools have been introduced by Adobe to document Adobe's Experience Data Mo
## Requirements

- `npm` version 3.10.8 or up
- `node` v14 or up
- `node` v16.18, v18, or v20 or up

## Example Output

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"unist-util-select": "5.0.0"
},
"engines": {
"node": ">= 14.0.0"
"node": "^16.18.0 || ^18.0.0 || >= 20.0.0"
},
"repository": {
"type": "git",
Expand Down