Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: bump minimun Node.JS version to Node 16.18 #523

Closed
wants to merge 1 commit into from

Conversation

aloisklink
Copy link
Contributor

@aloisklink aloisklink commented Aug 3, 2023

Bump the minimum version of Node.JS to Node v16.18. Node v14, v15, v17, v19 are all no longer being maintained, see https://github.com/nodejs/release#release-schedule

Additionally, PR #516 updated mdast-util-to-string to 4.0.0, unist-util-inspect to 8.0.0, and unist-util-select to 5.0.0, and all of these packages now require Node.JS v16 (at least according to their release notes, they still seem to run okay on Node.JS v14)

Node v16.18 was picked as the minimum required Node.JS version, since that's the most commonly available Node.JS version in OS package repos, see https://repology.org/project/nodejs/versions

BREAKING CHANGE: The minimum supported version of NodeJS is now 16.18, 18.x, or >= 20.x. NodeJS v14, v15, v17, and v19 are no longer supported.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #523 (959f032) into main (119f517) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          11       11           
  Lines        2039     2039           
=======================================
  Hits         2034     2034           
  Misses          5        5           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Bump the minimum version of Node.JS to Node v16.18.
Node v14, v15, v17, v19 are all no longer being maintained, see
https://github.com/nodejs/release#release-schedule

Node v16.18 was picked as the minimum required Node.JS version, since
that's the most commonly available Node.JS version in OS package repos,
see https://repology.org/project/nodejs/versions

BREAKING CHANGE: The minimum supported version of NodeJS is now 16.18,
                 18.x, or >= 20.x. NodeJS v14, v15, v17, and v19 are
                 no longer supported.
@aloisklink aloisklink force-pushed the build/drop-nodev14-support branch from f1b2743 to 959f032 Compare August 3, 2023 11:17
@tripodsan
Copy link
Collaborator

fixed with #575

@tripodsan tripodsan closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants