Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Safari: Strings are unlocalized in pt_BR, zh_CN, zh_TW locales #721

Open
Adobe-G11N-I18N-L10N-Team opened this issue Apr 26, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@Adobe-G11N-I18N-L10N-Team
Copy link

Adobe-G11N-I18N-L10N-Team commented Apr 26, 2024

Description
Strings are unlocalized in in pt_BR, zh_CN, zh_TW locales in Safari browser

To Reproduce
Steps to reproduce the behavior:

  1. Install Sidekick extension https://apps.apple.com/ch/app/aem-sidekick/id1605191569?l=en&mt=12
  2. Launch Safari browser
  3. Right click on extension button > Manage Extension > Options
    Expected behavior
    All strings is localized
    Note: issue related to [l10n] Safari: Strings are unlocalized in pt_BR, zh_CN, zh_TW locales #592
    Screenshots
    unloc_strings_zh_TW
    unloc_strings_02_zh_TW
    unloc_strings_03
    unloc_strings_02
    unloc_strings

unloc_strings_03_zh_TW

@Adobe-G11N-I18N-L10N-Team Adobe-G11N-I18N-L10N-Team added the bug Something isn't working label Apr 26, 2024
@rofe
Copy link
Contributor

rofe commented Jun 25, 2024

@asthabh23 could you take a look into this?

@birtles
Copy link

birtles commented Oct 21, 2024

I believe this is a bug in Safari itself, see: https://forums.developer.apple.com/forums/thread/762697

birtles added a commit to birchill/10ten-ja-reader that referenced this issue Oct 21, 2024
Chrome onlys seems to recognize zh_CN and in my testing zh_CN works in
Firefox too so let's use that.

Safari doesn't seem to handle subtags correctly so this still won't work
there. See:

- https://forums.developer.apple.com/forums/thread/762697
- adobe/helix-sidekick-extension#721

Fixes #2051 for Chrome at least.
birtles added a commit to birchill/10ten-ja-reader that referenced this issue Oct 21, 2024
Chrome onlys seems to recognize zh_CN and in my testing zh_CN works in
Firefox too so let's use that.

Safari doesn't seem to handle subtags correctly so this still won't work
there. See:

- https://forums.developer.apple.com/forums/thread/762697
- adobe/helix-sidekick-extension#721

Fixes #2051 for Chrome at least.
@xeenon
Copy link

xeenon commented Oct 21, 2024

Testing this extension from main in Safari 18, and I do see the Chinese locale from zh_CN being used. Is this still an issue?

@Adobe-G11N-I18N-L10N-Team
Copy link
Author

Issue is not fixed, verified on 6.50.0, Safari version 18.0.1
6 50 0 ptb
6 50 0 chs 1
6 50 0 chs 2

@xeenon
Copy link

xeenon commented Oct 23, 2024

After some more testing, I found the issue. You also need to set the Region to "China mainland" or "Taiwan" to see the zh_CN or zh_TW locales, otherwise Safari 18 is looking for zh_US or whatever home region you are using.

I have a fix for this in Safari to use the Chinese locales no matter what region you have selected.

@rofe
Copy link
Contributor

rofe commented Oct 24, 2024

@Adobe-G11N-I18N-L10N-Team can you please re-verify with the region setting explained above?

@Adobe-G11N-I18N-L10N-Team
Copy link
Author

@rofe Help topics strings are unlocalized with location changed to correct one, this is applied to all locales. Strings in right-click dropdown and other strings in Options are fixed. Verified on 6.50.1.
6 50 1 pt_BR
6 50 1 zh_CN 1
6 50 1 zh_CN 2
6 50 1 zh_TW 2
6 50 1 zh_TW
6 50 1 de_DE

@rofe
Copy link
Contributor

rofe commented Oct 26, 2024

Ok thanks for confirming that the browser UI is now correctly localized.

For help content: are all non-english languages affected equally? Have you tried completly removing and readding the extension? The english content may be coming out of local storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants