-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[l10n] Safari: Strings are unlocalized in pt_BR, zh_CN, zh_TW locales #721
Comments
@asthabh23 could you take a look into this? |
I believe this is a bug in Safari itself, see: https://forums.developer.apple.com/forums/thread/762697 |
Chrome onlys seems to recognize zh_CN and in my testing zh_CN works in Firefox too so let's use that. Safari doesn't seem to handle subtags correctly so this still won't work there. See: - https://forums.developer.apple.com/forums/thread/762697 - adobe/helix-sidekick-extension#721 Fixes #2051 for Chrome at least.
Chrome onlys seems to recognize zh_CN and in my testing zh_CN works in Firefox too so let's use that. Safari doesn't seem to handle subtags correctly so this still won't work there. See: - https://forums.developer.apple.com/forums/thread/762697 - adobe/helix-sidekick-extension#721 Fixes #2051 for Chrome at least.
Testing this extension from |
After some more testing, I found the issue. You also need to set the Region to "China mainland" or "Taiwan" to see the I have a fix for this in Safari to use the Chinese locales no matter what region you have selected. |
@Adobe-G11N-I18N-L10N-Team can you please re-verify with the region setting explained above? |
@rofe Help topics strings are unlocalized with location changed to correct one, this is applied to all locales. Strings in right-click dropdown and other strings in Options are fixed. Verified on 6.50.1. |
Ok thanks for confirming that the browser UI is now correctly localized. For help content: are all non-english languages affected equally? Have you tried completly removing and readding the extension? The english content may be coming out of local storage. |
Description
Strings are unlocalized in in pt_BR, zh_CN, zh_TW locales in Safari browser
To Reproduce
Steps to reproduce the behavior:
Expected behavior
All strings is localized
Note: issue related to [l10n] Safari: Strings are unlocalized in pt_BR, zh_CN, zh_TW locales #592
Screenshots
The text was updated successfully, but these errors were encountered: