Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Safari: Strings are unlocalized in pt_BR, zh_CN, zh_TW locales #592

Closed
makarovan opened this issue Nov 7, 2023 · 2 comments · Fixed by #630
Closed

[l10n] Safari: Strings are unlocalized in pt_BR, zh_CN, zh_TW locales #592

makarovan opened this issue Nov 7, 2023 · 2 comments · Fixed by #630
Labels
bug Something isn't working good first issue Good for newcomers released

Comments

@makarovan
Copy link

Description
Strings are unlocalized in in pt_BR, zh_CN, zh_TW locales in Safari browser

To Reproduce
Steps to reproduce the behavior:

  1. Install Sidekick extension https://apps.apple.com/ch/app/aem-sidekick/id1605191569?l=en&mt=12
  2. Launch Safari browser
  3. Right click on extension button > Manage Extension > Options

Expected behavior
All strings are localized

Screenshots
pt_br
zh_cn
zh_tw

Additional context
Issue is not reproducible on ko_KR
@makarovan makarovan added the bug Something isn't working label Nov 7, 2023
@rofe rofe added the good first issue Good for newcomers label Nov 7, 2023
@rofe rofe mentioned this issue Dec 11, 2023
Merged
@rofe rofe closed this as completed in #630 Dec 11, 2023
@trieloff
Copy link
Contributor

🎉 This issue has been resolved in version 6.38.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Adobe-G11N-I18N-L10N-Team
Copy link

@rofe Issue is not fixed, verified on Safari v6.40.3
chs safari options unloc
cht safari options unloc
ptb safari options unloc

Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(safari): fix i18n issues adobe/helix-sidekick-extension
4 participants
@trieloff @rofe @makarovan @Adobe-G11N-I18N-L10N-Team