Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire binary hlx distribution #696

Closed
stefan-guggisberg opened this issue Mar 28, 2019 · 3 comments
Closed

Retire binary hlx distribution #696

stefan-guggisberg opened this issue Mar 28, 2019 · 3 comments
Assignees

Comments

@stefan-guggisberg
Copy link
Contributor

Overview

Recent binary hlx releases are all broken. The last know to work release is v0.13.8. See related issues:

Details

The binary hlx executable is build using node-packer. node-packer embeds Node 8.3 runtime within the native executable.

As of #397 (0528466) Node >=8.9 is required to run the CLI.

OTOH the node-packer project is abandoned, the current release is 2 years old (bundling Node 8.3 runtime). I forked the project and ported the runtime to 8.15 and 10.15, only to run into new issues (e.g. #687, #689, failure to load native addons, etc). There are potentially a lot more issues. Fixing those issues would require a deep dive into v8, libuv, libsquash and Node core C/C++ code, hardly worth the effort.

While there are other projects which create native executables from node apps (pkg, enclose, nexe, electron etc) none of them work for helix-cli (lack of native addon support, no dynamic requires, etc).

Proposed Actions

I suggest we stop providing binary hlx builds, at least until we find a viable solution.
This would mean we remove any reference from READMEs, docs etc and remove the build job on CircleCi.

@stefan-guggisberg stefan-guggisberg added the question Further information is requested label Mar 28, 2019
@stefan-guggisberg stefan-guggisberg self-assigned this Mar 28, 2019
@stefan-guggisberg stefan-guggisberg removed the question Further information is requested label Apr 2, 2019
stefan-guggisberg added a commit that referenced this issue Apr 2, 2019
stefan-guggisberg added a commit that referenced this issue Apr 2, 2019
@stefan-guggisberg
Copy link
Contributor Author

resolved according to proposal

@tripodsan
Copy link
Contributor

tripodsan commented Apr 9, 2019

@stefan-guggisberg I think this file is no longer needed, correct?
https://github.com/adobe/helix-cli/blob/master/cli_install.sh

@stefan-guggisberg
Copy link
Contributor Author

fixed in de2c914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants