Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hlx build of demo project fails #654

Closed
stefan-guggisberg opened this issue Mar 18, 2019 · 5 comments
Closed

hlx build of demo project fails #654

stefan-guggisberg opened this issue Mar 18, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@stefan-guggisberg
Copy link
Contributor

Description
hlx build of a newly created project with hlx demo fails with the following error:

/Users/stefan/Downloads/demo/src/html.htl: Cannot find module './html.pre.js
2019-03-18 16:52:42.428 error: encountered unhandled promise rejection at process level: [object Promise], reason: [object Object]

To Reproduce
Steps to reproduce the behavior:

  1. Install binary hlx (version 0.13.9 or 0.13.10)
  2. hlx demo demo && cd demo && hlx up
  3. See error

Expected behavior
No error, browser launches and renders the project

Version:
0.13.9 and 0.13.10

Additional context
Works with 0.13.8

@stefan-guggisberg stefan-guggisberg added the bug Something isn't working label Mar 18, 2019
@stefan-guggisberg stefan-guggisberg self-assigned this Mar 18, 2019
@stefan-guggisberg
Copy link
Contributor Author

only the binary builds of hlx seem to be affected.

@stefan-guggisberg
Copy link
Contributor Author

Found the root cause: As of version 0.13.9 helix-cli doesn't work properly on Node 8.3 anymore. Version 0.13.8 works as expected on Node 8.3.

see #657

Since the binary hlx embeds Node 8.3 it's affected as of version 0.13.9.

@tripodsan
Copy link
Contributor

can you include a more recent node version in the hlx binary? for example: node v8.15.1 ?

@stefan-guggisberg
Copy link
Contributor Author

I already spent 3 days working on porting the packaged Node runtime. It's non trivial. It involves patching Node sources and gyp files :/ More recent Node versions introduce new fs methods (e.g. copyFile) which need to be ported to support squashfs...

stefan-guggisberg added a commit that referenced this issue Mar 22, 2019
@stefan-guggisberg
Copy link
Contributor Author

fixed via workaround 12c5092
closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants