Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hlx binary distribution #127

Closed
stefan-guggisberg opened this issue Aug 30, 2018 · 13 comments
Closed

hlx binary distribution #127

stefan-guggisberg opened this issue Aug 30, 2018 · 13 comments
Assignees
Labels
enhancement New feature or request

Comments

@stefan-guggisberg
Copy link
Contributor

follow-up on #19

proposal:

  • move hlx installer POC to adobe/helix-cli-dist
  • integrate helix-cli-dist with CI, i.e. build and and tag install.sh on every helix-cli npm release
  • Getting Started doc: refer to option to download hlx instead of building it using npm

todo:

  • verify licenses of packaged dependencies WRT distribution
  • check whether binary distribution would be subject to export restrictions

i'll create separate issues for the todo's.

@tripodsan
Copy link
Contributor

silly question: why a new repo and not have the installer logic in the helix-cli repository?

@stefan-guggisberg
Copy link
Contributor Author

the idea is to host the binaries on GH, at least for now.

every binary release adds ~40mb. cloning helix-cli would get slower and slower.

@tripodsan
Copy link
Contributor

every binary release adds ~40mb. cloning helix-cli would get slower and slower.

good point

@stefan-guggisberg
Copy link
Contributor Author

another option would be to come up for an alternative upload location.

@tripodsan
Copy link
Contributor

tripodsan commented Aug 31, 2018

I would put them to the releases. see
https://help.github.com/articles/about-releases/#limitations-on-binary-files

for example: https://github.com/adobe/helix-cli/releases/tag/v0.3.2

@stefan-guggisberg can you create a installer for the v0.3.2 release and upload it to that page?

@stefan-guggisberg
Copy link
Contributor Author

@tripodsan good point. i'll have a look.

@stefan-guggisberg
Copy link
Contributor Author

@tripodsan

done.

curl -LO https://github.com/adobe/helix-cli/releases/download/v0.3.2/hlx_install.sh
chmod +x
./hlx_install.sh

the only drawback is that you have to specify the version in the url. i haven't found a way (url) that allows to download the latest version.

@tripodsan
Copy link
Contributor

the only drawback is that you have to specify the version in the url. i haven't found a way (url) that allows to download the latest version.

I think we can achieve this eventually with a redirect on something like: https://helix.io/instal.sh

@trieloff
Copy link
Contributor

trieloff commented Sep 3, 2018

Are we going to run into space limits if we do snapshot releases via CircleCI?

@trieloff
Copy link
Contributor

trieloff commented Sep 3, 2018

We can probably use something like https://adobe.ly/helix-cli

This is powered by bitly, which has an API for updating shortened links: https://dev.bitly.com/v4_documentation.html (only for paying customers, like Adobe)

@tripodsan
Copy link
Contributor

I wouldn't do snapshot releases for binary distributions to github... however, github writes:

We don't limit the total size of your binary release files, nor the bandwidth used to deliver them. However, each individual file must be under 2 GB in size.

@trieloff
Copy link
Contributor

trieloff commented Sep 3, 2018

If you have an S3 bucket, we can also deploy snapshots to S3.

@tripodsan
Copy link
Contributor

@stefan-guggisberg this can be considered done. no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants