Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

nodegit doesn't build nor install on node version 10 #13

Closed
trieloff opened this issue Aug 13, 2018 · 9 comments
Closed

nodegit doesn't build nor install on node version 10 #13

trieloff opened this issue Aug 13, 2018 · 9 comments
Assignees

Comments

@trieloff
Copy link
Contributor

Homebrew's latest node formula is for Node 10.8, but according to nodegit/nodegit#1532 only Node 10.3 works.

@stefan-guggisberg
Copy link
Contributor

stefan-guggisberg commented Aug 13, 2018

current nodegit (v0.22.2) doesn't build nor install on node version 10.

see nodegit/nodegit#1490

workaround for the time being: use node version 8.

@stefan-guggisberg stefan-guggisberg changed the title nodegit does not work with node 10 from homebrew nodegit doesn't build nor install on node version 10 Aug 13, 2018
@trieloff
Copy link
Contributor Author

I downgraded to node 8, but this might be a reason to consider using https://github.com/es-git/es-git as a fallback.

trieloff added a commit that referenced this issue Aug 13, 2018
@stefan-guggisberg
Copy link
Contributor

as a workaround, you can use the binary distribution of hlx which is agnostic to the current node environment (see adobe/helix-cli#127).

hlx_install.sh

@stefan-guggisberg
Copy link
Contributor

fixed by using @adobe/nodegit built on adobe/nodegit, a nodegit fork with PR nodegit/nodegit#1519 applied.

@stefan-guggisberg
Copy link
Contributor

once node 10 is supported in the official nodegit project i'll revert to using the official nodegit npm package.

@stefan-guggisberg
Copy link
Contributor

stefan-guggisberg commented Sep 26, 2018

reopening, since long build times made us revert to using official nodegit/nodegit v0.22.2, see #32

@stefan-guggisberg
Copy link
Contributor

the latest nodegit release is a major improvement, e.g.:

  • node 10 support
  • doesn't compile openssl

however, there's now an issue with node 8: nodegit/nodegit#1575

we'll have to wait until said issue gets fixed before we can update the nodegitdependency to 0.23.?.

@stefan-guggisberg
Copy link
Contributor

an update to nodegit v0.23.0 and nodegit/nodegit#1575:

apparently node v8.12 and v10 work. i was using node v8.9 and ran into above issue.

@stefan-guggisberg
Copy link
Contributor

fixed in 723c954

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants