Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Apikey environment and some refactoring #57

Merged
merged 5 commits into from
May 26, 2020
Merged

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented May 25, 2020

Description

fix for #50, goes together with adobe/aio-cli-plugin-app#239

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@meryllblanchet meryllblanchet requested a review from shazron May 25, 2020 13:09
@meryllblanchet meryllblanchet added the enhancement New feature or request label May 25, 2020
@moritzraho moritzraho changed the title common api key and some refactoring Global Apikey environement and some refactoring May 25, 2020
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          311       307    -4     
  Branches        39        39           
=========================================
- Hits           311       307    -4     
Impacted Files Coverage Δ
generators/add-action/analytics/index.js 100.00% <ø> (ø)
generators/add-action/audience-manager-cd/index.js 100.00% <ø> (ø)
generators/add-action/campaign-standard/index.js 100.00% <ø> (ø)
generators/add-action/customer-profile/index.js 100.00% <ø> (ø)
generators/add-action/target/index.js 100.00% <ø> (ø)
generators/add-web-assets/exc-react/index.js 100.00% <100.00%> (ø)
lib/ActionGenerator.js 100.00% <100.00%> (ø)
lib/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38fbde8...b0735dc. Read the comment docs.

@shazron shazron changed the title Global Apikey environement and some refactoring Global Apikey environment and some refactoring May 26, 2020
@moritzraho moritzraho merged commit b8aeea9 into master May 26, 2020
@purplecabbage purplecabbage deleted the common-api-key branch June 25, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants