Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a SERVICE_API_KEY .env variable on init & use #239

Merged
merged 5 commits into from
May 26, 2020
Merged

Set a SERVICE_API_KEY .env variable on init & use #239

merged 5 commits into from
May 26, 2020

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented May 19, 2020 •
edited
Loading

Description

This goes together with adobe/generator-aio-app#57

Related Issue

adobe/generator-aio-app#50

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@moritzraho moritzraho mentioned this pull request May 25, 2020
Merged
10 tasks
@moritzraho moritzraho changed the title [WIP] set a SERVICE_API_KEY env variable on init & use Set a SERVICE_API_KEY .env variable on init & use May 25, 2020
@moritzraho moritzraho marked this pull request as ready for review May 25, 2020 15:30
@moritzraho moritzraho requested a review from shazron May 25, 2020 15:30
@meryllblanchet meryllblanchet added the enhancement New feature or request label May 25, 2020
@moritzraho moritzraho merged commit 5406d4f into adobe:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazron shazron shazron approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moritzraho @shazron @meryllblanchet