Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add launch_prefix_url to .env #137

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Don't add launch_prefix_url to .env #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
757f8a2
Use experience-stage for stage env
Himavanth Apr 12, 2021
3453414
dont add launch_prefix_url to .env
Himavanth Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions generators/add-web-assets/exc-react/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const path = require('path')
const Generator = require('yeoman-generator')

const utils = require('../../../lib/utils')
const { webAssetsDirname, dotenvFilename } = require('../../../lib/constants')
const { webAssetsDirname } = require('../../../lib/constants')
const { sdkCodes } = require('../../../lib/constants')

class ExcReactGenerator extends Generator {
Expand Down Expand Up @@ -72,15 +72,6 @@ class ExcReactGenerator extends Generator {
},
true
)
// add env variable to load ui in exc shell
utils.appendOrWrite(
this,
this.destinationPath(dotenvFilename),
`## URL prefix used to run your application in the Adobe Experience Cloud Shell
AIO_LAUNCH_URL_PREFIX="https://experience.adobe.com/?devMode=true#/custom-apps/?localDevUrl="
`,
'AIO_LAUNCH_URL_PREFIX'
)
}

async install () {
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"yeoman-test": "^2.6.0"
},
"dependencies": {
"@adobe/aio-lib-env": "^1.1.0",
"fs-extra": "^9.0.0",
"js-yaml": "^3.14.0",
"lodash.clonedeep": "^4.5.0",
Expand Down
4 changes: 0 additions & 4 deletions test/generators/add-web-assets/exc-react.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@ describe('prototype', () => {
})

function assertEnvContent (prevContent) {
assert.fileContent(
'.env',
'AIO_LAUNCH_URL_PREFIX="https://experience.adobe.com/?devMode=true#/custom-apps/?localDevUrl="'
)
assert.fileContent('.env', prevContent)
}

Expand Down