Don't add launch_prefix_url to .env #137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 619 618 -1
Branches 82 82
=========================================
- Hits 619 618 -1
Continue to review full report at Codecov.
|
| utils.appendOrWrite( | ||
| this, | ||
| this.destinationPath(dotenvFilename), | ||
| `## URL prefix used to run your application in the Adobe Experience Cloud Shell | ||
| AIO_LAUNCH_URL_PREFIX="https://experience.adobe.com/?devMode=true#/custom-apps/?localDevUrl=" | ||
| AIO_LAUNCH_URL_PREFIX="${launchPrefix}" |
There was a problem hiding this comment.
Should we remove this one from the .env, in adobe/aio-cli-plugin-app#396 you already set the default.
If someone inits an app in stage and then wants to switch to prod he needs to edit that line in the .env. If we don't include it then app plugin will be able to set the correct default
There was a problem hiding this comment.
I agree. These kind of overrides could just be documented instead of actually putting in .env.
There was a problem hiding this comment.
👍 for doc so then feel free to remove the env var 🙂
Himavanth
changed the title
Description
This is already being handled in aio-cli-plugin-app
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: