-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Restore the QuickOpen.basicMatchSort and friends #9747
Conversation
dangoor
commented
Oct 30, 2014
This change broke a few extensions. Looking at the fix, it seems that all QuickOpen plugins will likely need these functions, so we may as well re-export them as we have been doing rather than requiring the extensions to all add another import. If we do decide to deprecate these later, we should do so with deprecation warnings (something we weren't doing when these were moved to the StringMatch module). Revert "Marked as deprecated by #2462 in Sprint 19" This reverts commit 49e0827.
LGTM |
Restore the QuickOpen.basicMatchSort and friends
Sorry about this guys. :( |
@le717 No problem. I can certainly see how something that appeared to be deprecated since sprint 19 should be safe to remove. |
@dangoor Would you like me to submit a PR marking these using |
@le717 No, I actually considered leaving these removed and decided to put them back because it made the extension code a bit uglier. So, I updated the comment to reflect that I think these should stay. |
Yea, that makes sense. However, since they are convenience exports, it probably should be noted somewhere there is a chance they might break later on (just as a general statement, not necessarily going to happen). |
You could almost say that about any of our APIs... there's always a chance they can break later on. As much as possible, though, when we do decide to break them, we will try to put deprecation warnings on first. |